Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp955923pxa; Wed, 5 Aug 2020 17:33:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAktJl5+Atq8b1UPewewYv5+bCtaqC350G/oFtQ0u0iGT4zAnJUDfkG52h4C0k6qaOXq0j X-Received: by 2002:a50:a187:: with SMTP id 7mr1753663edk.71.1596673984963; Wed, 05 Aug 2020 17:33:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596673984; cv=none; d=google.com; s=arc-20160816; b=l0txG0Gf0a+IKOCn42ZKpRF/AkhjeFeQOkRgW2ivYNWVqXVjXgoWRLbXvEdOrUOzQ8 8dPaWu4EffxBxBKDFJ51E3CM0kRVPokG7yuH6bJkcKYbZcJVY6pzhivLkZzo2uHkdRYb 8boJS0qCYS+iw2S1BcSLivCDF88LYCqFC013d3kola825LH0A5vE0+HbdnxAW93mNI47 43sD3M0LnGdZNlUgNYxvuueQFdpdfa7Yx3As5hdlnOY7d6xxm8IUiZ88FCv62BIMTrfJ 5pGetovrlYlZdNU7/rUgCZi+QtQ2VZ/eFeke3B7VlM2N3PwRrazgy/t2Oa+MMGNwI1eP WiZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=COlM6ZwpJBn0yZ7U5zGmwKi2QBKcTNFY6uKqQQLWL9I=; b=y5C/Lpcb2yYF6M3x+V2wSkcat2zmb11JJ9HUUz/4L9wjJfur/pi3xnIiPXxH2G9CxO 0h/oSx2PPaKcwvVz/2v1liZFCPXpPwd4JZwpALRKBzdLeIE5wwXe+WdqxdVrcqrnyQ6V i7CkzjGZaJhnuAsacT3HLqGhJ+Injc+G/cFJq3/jvIkmzHcyYyARnXhOszYLJSL2/Xds b1+FNtlZEfILL8YupqFeAqQ1w2tAy7QYbbqf4FhutKyVxMDFSWhrAFW7eDhJwNAj8MmJ kjkVO7bVyArHMt37wzpi0JTPmGUxR6Eyl2kYKzRT+d3EjzdPmBc62c3poqEfrklHK510 pHxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NyYpl8j7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si2297808edn.377.2020.08.05.17.32.40; Wed, 05 Aug 2020 17:33:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NyYpl8j7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbgHFAcA (ORCPT + 99 others); Wed, 5 Aug 2020 20:32:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:53050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbgHFAb5 (ORCPT ); Wed, 5 Aug 2020 20:31:57 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 741DB2173E; Thu, 6 Aug 2020 00:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596673917; bh=COlM6ZwpJBn0yZ7U5zGmwKi2QBKcTNFY6uKqQQLWL9I=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=NyYpl8j7GnE0b6Kl9PfXT74TEaVjbKcJZhVIYLuCXYezr42vioZTRPEVqIghVq1F4 zNIZU0xHD6nN48uda830HuH8BpUcKUyC/m9qlBIBKXRrYYuT+KwRh1A+dNmzWkX2Ye KUyGv5thzFRaFuJCm0Wn0WY0Ymm34tc/mAb9/oes= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1595413915-17867-2-git-send-email-rohitkr@codeaurora.org> References: <1595413915-17867-1-git-send-email-rohitkr@codeaurora.org> <1595413915-17867-2-git-send-email-rohitkr@codeaurora.org> Subject: Re: [PATCH v4 01/12] ASoC: qcom: Add common array to initialize soc based core clocks From: Stephen Boyd Cc: Ajit Pandey , Rohit kumar To: Rohit kumar , agross@kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, bjorn.andersson@linaro.org, broonie@kernel.org, devicetree@vger.kernel.org, lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, perex@perex.cz, plai@codeaurora.org, robh+dt@kernel.org, srinivas.kandagatla@linaro.org, tiwai@suse.com Date: Wed, 05 Aug 2020 17:31:56 -0700 Message-ID: <159667391634.1360974.15763918681460437981@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Rohit kumar (2020-07-22 03:31:44) > From: Ajit Pandey >=20 > LPASS variants have their own soc specific clocks that needs to be > enabled for MI2S audio support. Added a common variable in drvdata to > initialize such clocks using bulk clk api. Such clock names is > defined in variants specific data and needs to fetched during init. Why not just get all the clks and not even care about the names of them? Use devm_clk_bulk_get_all() for that, unless some clks need to change rates?