Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 05 Aug 2020 17:42:17 -0700 (PDT)
Message-Id: <20200805.174217.627457778756782771.davem@davemloft.net>
To:     min.li.xe@renesas.com
Cc:     richardcochran@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ptp: ptp_idt82p33: update to support adjphase
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1596568334-17070-1-git-send-email-min.li.xe@renesas.com>
References: <1596568334-17070-1-git-send-email-min.li.xe@renesas.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: <min.li.xe@renesas.com>
Date: Tue, 4 Aug 2020 15:12:14 -0400

> This update includes adjphase support, more debug logs, firmware name
> parameter, correct PTP_CLK_REQ_PEROUT support and use do_aux_work to
> do delay work.

Way too many changes in one patch, and some of them are not appropriate.

> +static char *firmware;
> +module_param(firmware, charp, 0);

We have various kernel interfaces for handling firmware loading and
names.  Please use them instead of a custom module paramter.  Module
paramters are significantly undesirable and addition of such will be
rejected by default.

Thank you.