Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 6 Aug 2020 09:15:13 +0800
From:   Kent Gibson <warthog618@gmail.com>
To:     Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 02/18] gpio: uapi: define uAPI v2
Message-ID: <20200806011513.GC11890@sol>
References: <20200725041955.9985-1-warthog618@gmail.com>
 <20200725041955.9985-3-warthog618@gmail.com>
 <CAMpxmJXocdDTvC7_76UwZ9FONn86p0MjZtorRKTR5bxN7PJy6g@mail.gmail.com>
 <20200805051853.GA122005@sol>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200805051853.GA122005@sol>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 05, 2020 at 01:18:53PM +0800, Kent Gibson wrote:
> On Tue, Aug 04, 2020 at 07:42:34PM +0200, Bartosz Golaszewski wrote:
> > On Sat, Jul 25, 2020 at 6:20 AM Kent Gibson <warthog618@gmail.com> wrote:

[snip]

> > > config, info, info_changed and event structs receive updated versions,
> > > and the first three new ioctls.
> > >
> > > Signed-off-by: Kent Gibson <warthog618@gmail.com>
> > > ---
> > 
> > Hi Kent,
> > 
> > Thanks a lot for your work on this. Please see comments below.
> > 
> > One thing I'd change globally for better readability is to have all
> > new symbols marked as v2 - even if they have no counterparts in v1. I
> > know libgpiod will wrap it all anyway but I think it's still a good
> > way to make our work in user-space easier.
> > 
> 
> Fair enough.  Oh joy.
> 

Given that the intent is to highlight that the symbols are related to the
v2 of the GPIO uAPI, and not the second version of a particular type, it
makes more sense to me that the v2 is placed adjacent to the GPIO in the
name.  e.g. gpioline_flag_v2 would become gpiov2line_flag.

Does that work for you?

Cheers,
Kent.