Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp987770pxa; Wed, 5 Aug 2020 18:34:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyJkIDi85sw/l+56XEn6lvO5/1GK7Dpbn901glFuf4cz3af3z9UiGKro7RfV3mxP2w8guh/ X-Received: by 2002:a17:906:2356:: with SMTP id m22mr2075326eja.124.1596677673770; Wed, 05 Aug 2020 18:34:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596677673; cv=none; d=google.com; s=arc-20160816; b=V9Qfjx9DsRAU0uxWxzNWVexQ205C4U8/+s+e9suYZGQ1wuGNWJFtT+D9iaDoHVvFXD FcBbvaRBHjdOvViWPG5ck3eWcL5KZvtN8Wvmmjgcp1Ytb0Q0jHuo2RfPfu6PTyra7qWv 3xKX0uosQ+URgTYpOiSFr5uwQJPTRWWVvp7VJlEwn4BFtQ9ilKYed6+RGcoVhSx+BH+X ZMrGEMHqezmhE0sGEXYL8VOpVW5OofragQBLFyviRY+Uf6cG6DCXbQ9oFl8HsK4BYj7V jtwF/K8RmS1lEpIphTwclNFhY9Syjhtmc6s+9tPNrZeTb1cKqy5vFacMjuuUxSJmeY2X XZag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject; bh=/XpHPYo75o7ZMpYRvdMQZHSzskCz81HgY+1cbSAHX9s=; b=TK7mEvvCwU/HAqY0hJDHXZFVhRhwHoPLU1vvuzuKxvzg3npLlBC+7cYXwnp+KK6wmX n3iNELKZ5mZJIx3oR+AJ87kgclHfLhKM16KpCHdJHr6uu5r0LKXm1pH9rvK5g5oBUiUR VRUIkMKDGfJKEYnxEMSXGRSzITKmu3/KWYM+PNeL8+HrlBJiBtv6tDlyeqmYwhCaOlxq VQ9fpw+p0/KG8v9lRmTvvF/CgKo99EYlGEGFGJkK3xrFKDR8zRMxI11rBj95gEBN9bef Bd0iEG3oowNkyaJKHA2sbXJue3usMRXJSaWF98sL727oXJxh+E5Zgj5nmTAW5CNpDofh msbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bw25si2368491ejb.10.2020.08.05.18.34.11; Wed, 05 Aug 2020 18:34:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726787AbgHFBeD (ORCPT + 99 others); Wed, 5 Aug 2020 21:34:03 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8770 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725998AbgHFBeD (ORCPT ); Wed, 5 Aug 2020 21:34:03 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 6E60EC939619170D8DC9; Thu, 6 Aug 2020 09:34:00 +0800 (CST) Received: from [127.0.0.1] (10.74.173.29) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Thu, 6 Aug 2020 09:33:51 +0800 Subject: Re: [v4 01/10] crypto: hisilicon/qm - fix wrong release after using strsep To: Markus Elfring , Sihang Chen , References: <96ffa633-dda1-7ad1-72da-5563906c1561@web.de> <425f4bdd-cf55-6537-28bf-0377564b531b@huawei.com> <5554863d-f0d7-a396-7d13-e187fa9ca6bf@web.de> CC: , , "David S. Miller" , Herbert Xu , Zaibo Xu , Zhou Wang From: "shenyang (M)" Message-ID: Date: Thu, 6 Aug 2020 09:33:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <5554863d-f0d7-a396-7d13-e187fa9ca6bf@web.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.173.29] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/8/5 14:04, Markus Elfring wrote: >> Thanks for your review. There is only one error branch need to do >> something uninit. So I think the jump is not necessary and will >> affect code reading.:) > > How does this concern fit to the Linux coding style? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=4da9f3302615f4191814f826054846bf843e24fa#n481 > > Regards, > Markus > > . > Got it, I'll fix this. Thanks, Yang