Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1138005pxa; Thu, 6 Aug 2020 00:00:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzU1pklUzf0ym6TdzZEBlEL9N/3d7lvqvu73ahb+PGzXH7l2ekfZeNoGLm8r/fncIEeRiP3 X-Received: by 2002:a17:906:840c:: with SMTP id n12mr2817054ejx.246.1596697223097; Thu, 06 Aug 2020 00:00:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596697223; cv=none; d=google.com; s=arc-20160816; b=ABKylMpdE6Wqt9fCRBUjSaCF9Cy+MDLqm3+TY7WQkS2nUTgS4LSeJve5QecujB8EFc KdiAOWeJ8TVu1l70sJWzOC8GzN937AhmA7g/XO+lo72uxh6rKZT7r5iWFoOOBMQ5LICv /g0fx0PQtvT2UEp+trImSF8erEMkB3x1I+8HyZyxvVx2pXEfRxw2URmrilyngRD5IcOu 4NJFkDHgVsLjS24IMpYNb0m14j8/yyeowRqTXv0ksnulr5i+w9IuBANoUt58s1Y0b7V9 Alhx6xpCYoRGNisD9mBPTlCcGtIbRJfaZaJBH01a1wVDT/6mrQf/ZdEQUUecyQNFHlLF M8OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=VEPooMqJ8++9ZGd2wUrnsGmqtscdVrBa+km65NyflEU=; b=OlaGN76pQFIKPJ1o0Sned5DTp1hkkFnSzKPiaJvFlNLObh0GWUsV7PNscLm3Qo+IQq llg1dYMnfly3L9w+3RsLOxQBXyyTIRpFfaONgN2XME4gpPSQxTdIn3TdOX77o+6WirD+ SbkGD8v0VXME/UfXpIhvxCdTdY99IhgeyWO0RQCs848/mXrasDF44z1cVFI8pwqAZAKz gllsI/nms11GJpkbeXF0DLkBVzac3L1tYuW8R4MBoAdtLAQWgrrMwnAjd0XfcQnbq8lH LDIk+QvHZE2hVufj4yGK1ZrxtwLV/tKtNWnyPe7wFUJ2mRYjhkzQDIqabaZ4B88YqdNC Q0Cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bo11si2528268edb.541.2020.08.06.00.00.00; Thu, 06 Aug 2020 00:00:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728485AbgHFG7G (ORCPT + 99 others); Thu, 6 Aug 2020 02:59:06 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8772 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728294AbgHFG7F (ORCPT ); Thu, 6 Aug 2020 02:59:05 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 7799A12F500FF488FFAD; Thu, 6 Aug 2020 14:59:00 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Thu, 6 Aug 2020 14:58:52 +0800 From: Jing Xiangfeng To: , , , , , CC: , Subject: [PATCH v2] scsi: ufs: ti-j721e-ufs: Fix error return in ti_j721e_ufs_probe() Date: Thu, 6 Aug 2020 15:01:35 +0800 Message-ID: <20200806070135.67797-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to return error code PTR_ERR() from the error handling case instead of 0. Fixes: 22617e216331 ("scsi: ufs: ti-j721e-ufs: Fix unwinding of pm_runtime changes") Signed-off-by: Jing Xiangfeng --- drivers/scsi/ufs/ti-j721e-ufs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/ufs/ti-j721e-ufs.c b/drivers/scsi/ufs/ti-j721e-ufs.c index 46bb905b4d6a..eafe0db98d54 100644 --- a/drivers/scsi/ufs/ti-j721e-ufs.c +++ b/drivers/scsi/ufs/ti-j721e-ufs.c @@ -38,6 +38,7 @@ static int ti_j721e_ufs_probe(struct platform_device *pdev) /* Select MPHY refclk frequency */ clk = devm_clk_get(dev, NULL); if (IS_ERR(clk)) { + ret = PTR_ERR(clk); dev_err(dev, "Cannot claim MPHY clock.\n"); goto clk_err; } -- 2.17.1