Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1173060pxa; Thu, 6 Aug 2020 01:07:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNK810BT7y0+BQZg6xP21R+hzhASY2vlX0KdLSzvc09WMzMcoMobvBVtLt9WipwtjJJ+QJ X-Received: by 2002:a17:906:a3d6:: with SMTP id ca22mr3145148ejb.78.1596701263584; Thu, 06 Aug 2020 01:07:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596701263; cv=none; d=google.com; s=arc-20160816; b=vVnPqHLklZZEYRjtxpBdPA8+iHHj/5qu5O1C0pFsAIbC/GQS0ZSJhfRs5KXC0xr9Lu SXm9MvXKntxq2l3FE+7CZOm+jk11WIgKEW4FANp60Kv8I/wDceZyWSQG7PEWqY9SKo8r Sps6hhs6JrQlMmCG9+cs0eZvIohEXz951PPSAzZtq9k/qJo5QmvAR6ky42LymDtLDFWZ XVdrnHPI2+BVqNklUWElw4ovZJxLFtTtZxgOmYS4/lhryhZC9zpqIgSC+0+VkJVgNHT6 eQmMHXrJhxd+TMq3tg3MdriWuGztNixtwwg9DgIodwrf4aB7jnqUzVpTwjpXTC8PqAE7 MT6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:from :subject:mime-version:message-id:date:dkim-signature; bh=LcmumI/w/Hm4tyicPdUaUNyCK6OWHY8oQP8ZiSpx1Fw=; b=BKvo0pp1OJCeuRaA2QYdYa3kX4qh9ooYeJmVJkWV7+Oha95Gtw2C0k2WIncfiJvAMR CEObMvR1J+zZBv3V4Ign8T3CPNzIAYqc8I3HjUTE0j9u9IeQpXlWDf4NkQsVNINgQfvj 9Mcc3gMCfT2mFug5npjET9W134qkvIZwAe6wcoJ2qt/U15m2ZfDpdzqblL8drSJaHuVl YbbEXDamKmBwB7lWjLgmgHem0v/TRYTvakym368mAjU3pUsurlSIr8u17E7UI2MWkR8c MhXFtuLbQnTAry0QbjGH4F4Ay+pZxMFPF8YoEpSfbb4rAo80sC1XUm5S28mY/XoELpVA MxQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=vpdDkZjd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f2si2822692ejr.18.2020.08.06.01.07.09; Thu, 06 Aug 2020 01:07:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=vpdDkZjd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728681AbgHFIGU (ORCPT + 99 others); Thu, 6 Aug 2020 04:06:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728473AbgHFIEN (ORCPT ); Thu, 6 Aug 2020 04:04:13 -0400 Received: from mail-ed1-x54a.google.com (mail-ed1-x54a.google.com [IPv6:2a00:1450:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8ADFC061756 for ; Thu, 6 Aug 2020 01:04:09 -0700 (PDT) Received: by mail-ed1-x54a.google.com with SMTP id x12so6896853eds.4 for ; Thu, 06 Aug 2020 01:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=LcmumI/w/Hm4tyicPdUaUNyCK6OWHY8oQP8ZiSpx1Fw=; b=vpdDkZjdkXkYqtDgFNnezY0woangi9BN3lrLOrCQwyy4EsZMw0fsi+t57Qm3ccQVBS 00a062McIzIhQbGYSxG5vsmjITQcYN7jdm5ab6WLIZ3FLWXcdmuCfuA88SxfBreLLCfc HE5HJAeSzQuQwkCwyHszArHeK6OIbutuS6bkiaRzXgo+P9NmpiU1tR/lerHt/LVOtw7T MOKsDoVAUy/jqkpdqagqAQviyhdOWfW0KowT2CG40pmUz2xRC5Vi0vE0um3Ad4yf3ddS k1epQ1Skpk0dMnKQmsw8O1rt7rQp6giPZOPMzCnhoGNv6YE6U1yX3g2Uk0DRUVOltRkA G4gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=LcmumI/w/Hm4tyicPdUaUNyCK6OWHY8oQP8ZiSpx1Fw=; b=hxLnKzeyv76iY49Lt70lWKPUWevlXKwjgAWV3Y7DRdyIjTme3gZur4lhfbBxc4xai8 1nbyU7LbGyxrKYn/KWVUQAgJ18YsWPYQEvQs1XPZMNvz6t+3UmD+LSszVgl2EdOQTWaG JESU+krlhDe1ag+oqmI5Q4u75hlsooo8ItLajCHz0fmBL4auepwV4n1JuhpJHfdaPq4f JBVZWaFj3qnpCJBkv/wGijFp0v6NymSGLHqfMUDIQs/Da19SgtLX7+RPZV1MqT57vdXU JcXRT92az2mVSTDNlxOuFp9i1RnKhGX5k6fsC6gz7gDnb4TVZzMOJrGkd8fMAKPsh6W8 SS0A== X-Gm-Message-State: AOAM533peWxt5bXiSxxGdmQ9mTCgA/tHiBdJInjcZ80/Fyt0TZtFROgD kuPE8jr0M/3p0TFRyJ/cxpQ0b+/8Tw== X-Received: by 2002:a17:906:d930:: with SMTP id rn16mr3267737ejb.330.1596701044913; Thu, 06 Aug 2020 01:04:04 -0700 (PDT) Date: Thu, 6 Aug 2020 10:03:41 +0200 Message-Id: <20200806080358.3124505-1-tweek@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6-goog Subject: [PATCH 1/2] selinux: add tracepoint on denials From: "=?UTF-8?q?Thi=C3=A9baud=20Weksteen?=" To: Paul Moore Cc: Nick Kralevich , "=?UTF-8?q?Thi=C3=A9baud=20Weksteen?=" , Joel Fernandes , Peter Enderborg , Stephen Smalley , Eric Paris , Steven Rostedt , Ingo Molnar , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Arnd Bergmann , linux-kernel@vger.kernel.org, selinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The audit data currently captures which process and which target is responsible for a denial. There is no data on where exactly in the process that call occurred. Debugging can be made easier by being able to reconstruct the unified kernel and userland stack traces [1]. Add a tracepoint on the SELinux denials which can then be used by userland (i.e. perf). Although this patch could manually be added by each OS developer to trouble shoot a denial, adding it to the kernel streamlines the developers workflow. [1] https://source.android.com/devices/tech/debug/native_stack_dump Signed-off-by: Thi=C3=A9baud Weksteen Suggested-by: Joel Fernandes Reviewed-by: Peter Enderborg --- MAINTAINERS | 1 + include/trace/events/avc.h | 37 +++++++++++++++++++++++++++++++++++++ security/selinux/avc.c | 5 +++++ 3 files changed, 43 insertions(+) create mode 100644 include/trace/events/avc.h diff --git a/MAINTAINERS b/MAINTAINERS index c8e8232c65da..0efaea0e144c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15426,6 +15426,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/gi= t/pcmoore/selinux.git F: Documentation/ABI/obsolete/sysfs-selinux-checkreqprot F: Documentation/ABI/obsolete/sysfs-selinux-disable F: Documentation/admin-guide/LSM/SELinux.rst +F: include/trace/events/avc.h F: include/uapi/linux/selinux_netlink.h F: scripts/selinux/ F: security/selinux/ diff --git a/include/trace/events/avc.h b/include/trace/events/avc.h new file mode 100644 index 000000000000..07c058a9bbcd --- /dev/null +++ b/include/trace/events/avc.h @@ -0,0 +1,37 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Author: Thi=C3=A9baud Weksteen + */ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM avc + +#if !defined(_TRACE_SELINUX_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_SELINUX_H + +#include + +TRACE_EVENT(selinux_audited, + + TP_PROTO(struct selinux_audit_data *sad), + + TP_ARGS(sad), + + TP_STRUCT__entry( + __field(unsigned int, tclass) + __field(unsigned int, audited) + ), + + TP_fast_assign( + __entry->tclass =3D sad->tclass; + __entry->audited =3D sad->audited; + ), + + TP_printk("tclass=3D%u audited=3D%x", + __entry->tclass, + __entry->audited) +); + +#endif + +/* This part must be outside protection */ +#include diff --git a/security/selinux/avc.c b/security/selinux/avc.c index d18cb32a242a..b0a0af778b70 100644 --- a/security/selinux/avc.c +++ b/security/selinux/avc.c @@ -31,6 +31,9 @@ #include "avc_ss.h" #include "classmap.h" =20 +#define CREATE_TRACE_POINTS +#include + #define AVC_CACHE_SLOTS 512 #define AVC_DEF_CACHE_THRESHOLD 512 #define AVC_CACHE_RECLAIM 16 @@ -706,6 +709,8 @@ static void avc_audit_post_callback(struct audit_buffer= *ab, void *a) u32 scontext_len; int rc; =20 + trace_selinux_audited(sad); + rc =3D security_sid_to_context(sad->state, sad->ssid, &scontext, &scontext_len); if (rc) --=20 2.28.0.163.g6104cc2f0b6-goog