Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1237197pxa; Thu, 6 Aug 2020 03:04:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCEMyCSZgrESGK+fVfUsJQ5tuV9oAZSnhKoDOLlbVJOUGplWKo6mc1xfNSZFL8LEClcnhm X-Received: by 2002:a17:906:b015:: with SMTP id v21mr3432473ejy.507.1596708270281; Thu, 06 Aug 2020 03:04:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596708270; cv=none; d=google.com; s=arc-20160816; b=unazkS6bpcOktmdiX1y3CYdryOsoXYC3ObPe2Mzez5JqvxMRDxzm99zTYBOmvWE6N0 YHgXNlcrivdARzRZadyIT3A2nQL28pXFd/lErE8F5RAZ5fdVtktI1CvRnn/MJOo2Pw9M 5treANrOZsoZSahBs6pShWcmSBnMBePQV5bq9WLWvpiqb7N79rGtt0kd+zxZ12dbBrgQ ca+QdMYslBNeP9n0UQ2MaRvOAGYE67A17HJnTs/98ZWOuXHUi5ts7EjhOPyNi67xNMnE mPkzO/YBUFcbyjm4MNyq7Bvno98yTNGBQ5aHXlBUtTB1klQOUHI7bkr9OWkcX4amAh1j dLVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date; bh=7e4l137Qcwrx0J/Tx24fQWNHNC3gDBsToU+QK3khZZM=; b=DKjVCcAsNbl5DMWpEicqXHcjX7X1942rraq74iFWduX+XMMwtp0vaz6DfYNTl+RcyO g6N6MzgL0+oIprWRFmrCjMX+kyNoQplZWyK1dZTWzX1QJ2zyA4OTe6svymbbzeG718RE eP6BCZ5BKBYqJPCCkvPZPcDfH5lPj6NquJv/BGnNAhuN+4GzMcmNvwF6pIxPucl90LxK MBUZ4QxCFgBq0FrJ39Z1pBgl56p0fc8VF+DTxoVX+JWCi4BQefE9iopkwVPyFYw3IXao AhF35YKTrYP7HMspOPYFllwrSpaz80suCTqWsdfnZ3MnNfD5LECEC8pY4lDgX92H0FE4 80cA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lk20si3006139ejb.703.2020.08.06.03.04.06; Thu, 06 Aug 2020 03:04:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729292AbgHFJ7b (ORCPT + 99 others); Thu, 6 Aug 2020 05:59:31 -0400 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:47241 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbgHFJ7R (ORCPT ); Thu, 6 Aug 2020 05:59:17 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R381e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04397;MF=richard.weiyang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0U4udH-7_1596707952; Received: from localhost(mailfrom:richard.weiyang@linux.alibaba.com fp:SMTPD_---0U4udH-7_1596707952) by smtp.aliyun-inc.com(127.0.0.1); Thu, 06 Aug 2020 17:59:12 +0800 Date: Thu, 6 Aug 2020 17:59:12 +0800 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v2] mm/sparse: only sub-section aligned range would be populated Message-ID: <20200806095912.GA97074@L-31X9LVDL-1304.local> Reply-To: Wei Yang References: <20200703031828.14645-1-richard.weiyang@linux.alibaba.com> <20200805214955.ds7y3nwjoz2ms37h@master> <1c817ced-8ad9-ce91-2992-94092bc065b3@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c817ced-8ad9-ce91-2992-94092bc065b3@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 06, 2020 at 09:29:36AM +0200, David Hildenbrand wrote: >On 05.08.20 23:49, Wei Yang wrote: >> On Fri, Jul 03, 2020 at 11:18:28AM +0800, Wei Yang wrote: >>> There are two code path which invoke __populate_section_memmap() >>> >>> * sparse_init_nid() >>> * sparse_add_section() >>> >>> For both case, we are sure the memory range is sub-section aligned. >>> >>> * we pass PAGES_PER_SECTION to sparse_init_nid() >>> * we check range by check_pfn_span() before calling >>> sparse_add_section() >>> >>> Also, the counterpart of __populate_section_memmap(), we don't do such >>> calculation and check since the range is checked by check_pfn_span() in >>> __remove_pages(). >>> >>> Clear the calculation and check to keep it simple and comply with its >>> counterpart. >>> >>> Signed-off-by: Wei Yang >>> >> >> Hi, Andrew, >> >> Is this one picked up? > >I can spot it in -next via the -mm tree: > >https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=68ad9becb23be14622e39ed36e5b0621a90a41d9 > Thanks ;-) Next time I would refer to this repo first. > >-- >Thanks, > >David / dhildenb -- Wei Yang Help you, Help me