Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1617398pxa; Thu, 6 Aug 2020 11:39:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzC9E/aO0fAstQJ5lQyAGLIfm7JWuMM5XzzPkRT7P5gSGctNnRUvX1q6Z5WYD6vaNKw+xhg X-Received: by 2002:a17:906:b890:: with SMTP id hb16mr6023307ejb.376.1596739182963; Thu, 06 Aug 2020 11:39:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596739182; cv=none; d=google.com; s=arc-20160816; b=oWpZd9pGkjGE9wqgHnvvEV+3JGLzIFJQlioCQ0DZXCMhIs+O7vBUVvRCMVM+Cmbf49 5VkhV9hqE5xvr2UWmODZ2n9HTV4AQkIVG51bFJmvC2YNohqUv2zdEsUTc9UJAy72Cr2v dcVpnvS0NwXMNzOERY/uytKtY/NL6B/YDBXWQM5zAwf6MhFmtIk2ssdH4tAbmOeVM5Uk VaVDqixitjg/VCowv6EushmAKBpPT4kIdNvDbDEWwj+1HACeMRVI6feusWnU+IxhKWYU wkQqSs2qwOImqE4/PttDAmBbFkwCJnEEWVW3G4l2g4qINjRRdDkPR7aYsxiuTQ+DUWoY Tmng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=xuh5L///1+6tqkx4SRS1RotcWxk6pfAkKpYSeAk+r38=; b=vrac2AUvmHOK4e3b3KV/DKnUPl32LLY5doN/lgQLoSi7uJpnlf0ABmeIketxwb+9su VGQ+Rs8uwG3SmFl9MWXuYGQaP55GvVjpkCIyPpO7EzlC/Synn3Gex4pOqNHZekxozIUz LJ3ClrEVYidP2LP1vkA1LNvRLO9UHC0awALhlcpKMAhgseyiQK41uX7d7Wcf4uJKZ6C4 wxXAI2kO2zwFDxPSbmuRI/IyzKI6d2g8Th67mfoVrRuEzvVd4CtTPkzYmaO6B+JD94PN VbspdWJ2rAE4RXXMI++FDKyP9PuTc030siHYqhdeQ5Qbe3Z1fuDJQXaqd1+tKY6wgQmp r7sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=n33x5l1l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fy21si3819842ejb.725.2020.08.06.11.39.21; Thu, 06 Aug 2020 11:39:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20150623.gappssmtp.com header.s=20150623 header.b=n33x5l1l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729747AbgHFSiA (ORCPT + 99 others); Thu, 6 Aug 2020 14:38:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728678AbgHFSfp (ORCPT ); Thu, 6 Aug 2020 14:35:45 -0400 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFD59C0617A4 for ; Thu, 6 Aug 2020 11:35:25 -0700 (PDT) Received: by mail-ed1-x542.google.com with SMTP id di22so28692509edb.12 for ; Thu, 06 Aug 2020 11:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xuh5L///1+6tqkx4SRS1RotcWxk6pfAkKpYSeAk+r38=; b=n33x5l1lnQt4xhfltS+h6aHkFiEpQKoEeN3DjgJEnrmZOtzrI8h41Nsk6jHcBU7xik J/NVfpDtxYJSCVapvIg1v6tK1NEXOH+a51WJKHAy8hfOlwgMz4ietam7OwxMFYQ978n3 +aOqhedYCnqrvHP4VHBfvtc2capnSIqaxd7gHLYLG0YE7QRFUV8P57kFaElHWxIO1T7z VIGC97g36bf9X35DK4mJeUK4eMk00yfJCj6CVZKCg61RTbXdQ+R8g/PitHxcRqU+HgeN 9o5DEbIlLZyNXCgXdhDMVarwDmOpGFHw4Uil9rnYH5I6lDX5xTZwrrjRDyzEd0cfJFfV gsHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xuh5L///1+6tqkx4SRS1RotcWxk6pfAkKpYSeAk+r38=; b=irliqBxdwWJmH3Tw9B/s2b4k4DmFkX50uYUstSWZnLTZhQU/g7yZmA14WZdSh7Pcl9 /k4K9Qp4Ir57cqGXHUELYOnWDUOxep4HFa7Pme0gPVxd0y9yjG18vhreb3i2pS5nZrS3 1mGlQsjtB+D7Yg3jQwhPDvajffc3o1to5HlOZoOYrbGENxwYCY4w/NwhNsIMhwPQiwK0 e2MVMxFD8ph46cSr3OsmS+SeSw8B6YunEodR0qRmtj5VyhdzlnrEnZJPAaDCMMwQAQ0G 5VBPspKWH57+gRKcIg2jAXs6ZUKCRiiXeVU9iW0ian0THoK+M3Womjt7VHTNUL0iiIjD c+RQ== X-Gm-Message-State: AOAM533TONQb1Om5VoyquTeajsHBsaMythRmnzcTUY7lfK9kkHODwG+s 34wn2mmPTJFetgKQAyzwV/wX6ApZNTVMakOv7C5x X-Received: by 2002:a50:93c5:: with SMTP id o63mr5213126eda.31.1596738924215; Thu, 06 Aug 2020 11:35:24 -0700 (PDT) MIME-Version: 1.0 References: <20200803123439.83400-1-jbi.octave@gmail.com> <20200803123439.83400-3-jbi.octave@gmail.com> In-Reply-To: <20200803123439.83400-3-jbi.octave@gmail.com> From: Paul Moore Date: Thu, 6 Aug 2020 14:35:13 -0400 Message-ID: Subject: Re: [RESEND PATCH 2/2] audit: uninitialize variable audit_sig_sid To: Jules Irenge Cc: linux-kernel@vger.kernel.org, Eric Paris , "moderated list:AUDIT SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 3, 2020 at 8:35 AM Jules Irenge wrote: > > Checkpatch tool reports > > "ERROR: do not initialise globals/statics to 0" > > To fix this, audit_sig_sid is uninitialized > As this is stored in the .bss section, > the compiler can initialize the variable automatically. > > Signed-off-by: Jules Irenge > --- > kernel/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Similar to patch 1/2, this will need to wait until after the merge window closes. -- paul moore www.paul-moore.com