Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1832742pxa; Thu, 6 Aug 2020 17:45:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBCQ3hExaDvoietCRuo5U0Q0RwLNHDhDaJRmLyCBxZpohVKWtjBwvcRIcyz+5ldPHKlkoQ X-Received: by 2002:aa7:ca54:: with SMTP id j20mr6561350edt.270.1596761138931; Thu, 06 Aug 2020 17:45:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596761138; cv=none; d=google.com; s=arc-20160816; b=SfhldL7MAL7Q3DAcVCvnTcgwHq0ZWahNK91w7bsJQNas70E3taMSoO8gwPMDQJfOUq LfQC++xf0oER+uPIPBsoT6iCly2++LMeFoMo8qiEJ9iBDUQSsIcAAlGcCNLOje2YsWjR Y2jSM3DJaYRXoSPnHfNIA3jrGSBAExHlHG5tn95ClQiVy/pKSnqsXRo73tquoDhmkmN9 FYu5nGd7xfvx5P1gByD2PI97FC3eBB7EsuQ2MZNU1vljdDq4oaYsYSQ13lG++ZZy5j4I jH61vRGjYoa6Z+7zlm7R8UToj93qbjtfPFoBDcULM1eeRpTwTPiuJa8nuZhMklQTkMOW yu/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=RgPXZVMrIckGX5DmfsQv8yNcqJQDdPlKU/7tj+0RAOU=; b=tCzZW7AvHzzqoD501W32TyXiCU0rMb2FizyYMXWtT6VTvNF3Y9/J/qebHXdzfn9Knl q4+lOyUjyc2958nwLxJoMk+gZkNEaR6lBD6szX/brJ7dR2dTKYTmELBxk3O8gYH9nxEG DknLua/jD8IPtLndoxsDDQKwcIhSCzgdnNJb+aAhZ1hVyyt4LwkOfHmvNRpFy0vxCRu5 pUShjdDHvcfw+9t1OlXTWlhLyOHGU5gvoBby9dmZmUS8dO5TkN9jT6p5/TUKFZQfD1Bs 9tW/z9BKgza5RPxzKtZRt+/K8oDGoM5/YuJ36fMdCdS+lF249VYf4K1Sc6BZAPj2JkCr MTxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=whSCyRwN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca23si4824924edb.68.2020.08.06.17.45.15; Thu, 06 Aug 2020 17:45:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=whSCyRwN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726294AbgHGAno (ORCPT + 99 others); Thu, 6 Aug 2020 20:43:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725998AbgHGAnn (ORCPT ); Thu, 6 Aug 2020 20:43:43 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EDF3C061574 for ; Thu, 6 Aug 2020 17:43:42 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id e4so65156pjd.0 for ; Thu, 06 Aug 2020 17:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RgPXZVMrIckGX5DmfsQv8yNcqJQDdPlKU/7tj+0RAOU=; b=whSCyRwNhpsO+yWDNZ4Cv5qNyZzpLOvp7DiNIK2pc3y7XGe+OgdIGNTYBxcj8Zsxh7 zYK0DR66GIMJwtwOdD0UOwxI+I5yf6lNoZKf3J+MlgeO82rATZ4XoQZuFSQZYbA+Y1el SO329IS71+vYIjIWEGLmlMbwErG6gv2/N5bXbsRi6xPMSzueQ04XdqNNg2be3HuBptsM +lJdAMvJDOB5JSozRVKaB3mz6n5A8d428+EF0qwNz/iOBaDczoIhMPLfszGtK7+UWBPK Z67kBsTMFlydITNfQZc49FejvfOdYfrpHYf+O4jF1aB9AFLpGA0O2BcoeO4qSphffdVH WRdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RgPXZVMrIckGX5DmfsQv8yNcqJQDdPlKU/7tj+0RAOU=; b=fZUz3P8X2jb+7x5ZO1eF7hOrDhGzomS8bKcQbFyvuu/zWoTlCZbKGxLTJuo0VsGMwB uvdLrCm+vrY4Ris/wMVx6GkPfiWm6F3furVi3T4SMhEFLZDy7j2oZpyVs2AXarWdhFkB xb36aoPBO3yC3Wu49LIeKnXeNG81PTlhhuY74vCTFzv7Idk7XCDbxEU1qFo2cz+9mHfY pklfww8VG6A4HTwYqegmP+ozQxXy2L4hMhGJBmKMiUzhPG5ATneFOBnZQw8v4Kd8rt5A yLmol/7MVDXzN1hjJABXSUCzBW0sbAuC/as/UEmBBdaLGRrvwnPFUfjN9ACg1k7gZJVj vJ/Q== X-Gm-Message-State: AOAM533kCnBc5LKEJWvOMsmdIzKxYfUDtYtkxLveqNHvKU7A25snO8sU dcubw+yJF9ZuMUxFVgOHFwh2IQ== X-Received: by 2002:a17:902:8a88:: with SMTP id p8mr10174683plo.184.1596761019053; Thu, 06 Aug 2020 17:43:39 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id b15sm9673497pft.116.2020.08.06.17.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2020 17:43:38 -0700 (PDT) Date: Thu, 6 Aug 2020 17:40:01 -0700 From: Bjorn Andersson To: John Stultz Cc: Steev Klimaszewski , Saravana Kannan , Thomas Gleixner , Jason Cooper , Marc Zyngier , Matthias Brugger , Andy Gross , Android Kernel Team , lkml , linux-arm-kernel , "moderated list:ARM/Mediatek SoC support" , linux-arm-msm , Hanks Chen , CC Hwang , Loda Chou Subject: Re: [PATCH v3 2/4] irqchip/qcom-pdc: Switch to using IRQCHIP_PLATFORM_DRIVER helper macros Message-ID: <20200807004001.GF20825@builder.lan> References: <20200718000637.3632841-1-saravanak@google.com> <20200718000637.3632841-3-saravanak@google.com> <78ad0914-6173-f753-9eba-b7cbfbb51fd6@kali.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 05 Aug 14:57 PDT 2020, John Stultz wrote: > On Wed, Aug 5, 2020 at 2:47 PM Steev Klimaszewski wrote: > > > > > > On 8/5/20 4:16 PM, Steev Klimaszewski wrote: > > > On 8/5/20 3:19 PM, Saravana Kannan wrote: > > >> On Wed, Aug 5, 2020 at 12:44 AM John Stultz wrote: > > >>> > > >>> So this is where I bashfully admit I didn't get a chance to try this > > >>> patch series out, as I had success with a much older version of > > >>> Saravana's macro magic. > > >>> > > >>> But unfortunately, now that this has landed in mainline, I'm seeing > > >>> boot regressions on db845c. :( This is in the non-modular case, > > >>> building the driver in. > > >> Does that mean the modular version is working? Or you haven't tried > > >> that yet? I'll wait for your reply before I try to fix it. I don't > > >> have the hardware, but it should be easy to guess this issue looking > > >> at the code delta. > > > For what it's worth, I saw this too on the Lenovo C630 (started on -next > > > around 20200727, but I didn't track it down as, well, there's less way > > > to get debug output on the C630. > > > > > > In my testing, module or built-in doesn't matter, but reverting does > > > allow me to boot again. > > > > > Actually - I spoke too soon - QCOM_PDC built-in with the commit reverted > > boots, however, module (on the c630 at least) doesn't boot whether it's > > a module or built-in. > > You may need to set deferred_probe_timeout=30 to give things a bit > more grace time to load. With the risk of me reading more into this than what you're saying, please don't upstream anything that depend this parameter to be increased. Compiling any of these drivers as module should not require the user to pass additional kernel command line parameters in order to get their device to boot. Regards, Bjorn > (I've mostly recently used qcom-pdc as a module with the android tree, > so the fw_devlink bits help there, but I need to re-check the state of > that upstream.) > > I'll dbl check this and dig more on the issue with the patch in > question once I can get back in my office later today. > > thanks > -john