Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp1938957pxa; Thu, 6 Aug 2020 21:33:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzymBmie7aLE3jJbzSYTmWigJvnmVwPBcfwIcaWxirF1zF4u5IQ1BBXVL9m4IfxkzbLGLYQ X-Received: by 2002:a17:906:868d:: with SMTP id g13mr7413769ejx.242.1596774817868; Thu, 06 Aug 2020 21:33:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596774817; cv=none; d=google.com; s=arc-20160816; b=e8M0lVwi+kAxlWK58k4L7yzB8CZqIvTAo4iMaj/mDrvuKj80zp2GZStJK9EKe3Jm2p VDWVNodKE6wETbmK6YWBlmS/HSn3CmwJSa5pbUVbZbSwxAht+/G8xFyFjACk0YRkW713 YMPog6WXk1CjQnT7BphT5n96o4scBKWrnBIFcSn3orqjvbHKC6jSJpyapNgcTZUV9lru /3M77fj3B9PnlCIX2kQmqpCnpqdGXBHaBG22xB09ueIYcoj3gz4d5ceZkZNDvUU9gjmH Qst3utnpj4cpcta+nQrWz7KGH0oRug0/NNTNiMBB2eQlpvgbOiyTM/vni2ujUQf5044m H1WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=hdmV/L7fCXs1B8NbyCfnL6ROSDZ9C99tPNr/4U6hRiw=; b=IYWNGJ/6AlsOT46AkdnZJEfB250xfpIY4LGJNa/iJxBr/SXASwi2/M/db7FwZ2sF8Y 6fEXsuau/el7jWwHR+t4QqOeqCN/8dl9KS3UNrA3PqkopB2d6NYdGrdSwJ2F1zd3f0BJ rJyeNCG2B/hO2ks9Roq7oeQyVT5p8h9IVENlCA1w4XLsaAPvcK07BJQfbd4Y0iHBvOfc pm0b3vIfFeeA05DLic6xiboVJ9NXisvkR0xaqCSxEl4JbCpAxyCvPY/M92cxd7yoGUSd cQA44ZClsznJOl0soKDL0FZHsEDwttIDBoZArJVzAe33zCY4sTOgLMaqbubEWxT43h0h 1hqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PivBxqhp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y10si4621839edu.397.2020.08.06.21.33.12; Thu, 06 Aug 2020 21:33:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PivBxqhp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725805AbgHGEcN (ORCPT + 99 others); Fri, 7 Aug 2020 00:32:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:45298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725265AbgHGEcN (ORCPT ); Fri, 7 Aug 2020 00:32:13 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 14E3621744; Fri, 7 Aug 2020 04:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596774732; bh=Fz8huZnhhkLwSX05aWzvKoou0vXMR2d8SOky+EI3hfo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PivBxqhpKW9l29vGnuwJI6ZUtWS9wpMsCHjc3KbEXRi35qRfLW8Eq2I51dbr5v5Vp y3VzXxjiHFgoz6S8sgt5uLnP49+A9eUa4zcnMZ/AqMf9nlm3iLtG2OtSbKmVazwCkQ qIQ0b2z/plBFKHgHrgl8VXcnraRUyFBRX5ksLUqQ= Date: Thu, 6 Aug 2020 21:32:11 -0700 From: Andrew Morton To: Srikar Dronamraju Cc: Michal Hocko , Michal Such?nek , David Hildenbrand , Gautham R Shenoy , Linus Torvalds , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Satheesh Rajendran , Mel Gorman , "Kirill A. Shutemov" , linuxppc-dev@lists.ozlabs.org, Christopher Lameter , Vlastimil Babka , Andi Kleen Subject: Re: [PATCH v5 3/3] mm/page_alloc: Keep memoryless cpuless node 0 offline Message-Id: <20200806213211.6a6a56037fe771836e5abbe9@linux-foundation.org> In-Reply-To: <20200703125823.GA26243@linux.vnet.ibm.com> References: <20200701084200.GN2369@dhcp22.suse.cz> <20200701100442.GB17918@linux.vnet.ibm.com> <184102af-ecf2-c834-db46-173ab2e66f51@redhat.com> <20200701110145.GC17918@linux.vnet.ibm.com> <0468f965-8762-76a3-93de-3987cf859927@redhat.com> <12945273-d788-710d-e8d7-974966529c7d@redhat.com> <20200701122110.GT2369@dhcp22.suse.cz> <20200703091001.GJ21462@kitsune.suse.cz> <20200703092414.GR18446@dhcp22.suse.cz> <20200703105944.GS18446@dhcp22.suse.cz> <20200703125823.GA26243@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 Jul 2020 18:28:23 +0530 Srikar Dronamraju wrote: > > The memory hotplug changes that somehow because you can hotremove numa > > nodes and therefore make the nodemask sparse but that is not a common > > case. I am not sure what would happen if a completely new node was added > > and its corresponding node was already used by the renumbered one > > though. It would likely conflate the two I am afraid. But I am not sure > > this is really possible with x86 and a lack of a bug report would > > suggest that nobody is doing that at least. > > > > JFYI, > Satheesh copied in this mailchain had opened a bug a year on crash with vcpu > hotplug on memoryless node. > > https://bugzilla.kernel.org/show_bug.cgi?id=202187 So... do we merge this patch or not? Seems that the overall view is "risky but nobody is likely to do anything better any time soon"?