Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: JjKhTN/h+JuPdk2ZWQPboQM8yz1o9R54Zzmcj2/0fCEneA4rasjcodTeAfM7f83qI7m8K4PPoV
 XAcjtjskPHSQ==
IronPort-SDR: +C3Z9pz0fRky7yCNjnEdHNu/WvAqzU/aGe8Hn1qgCxbgl0sJD3Xy43tBK40JXqa2ThRzd63OaN
 XCbIwri0VMSQ==
From:   "Ooi, Joyce" <joyce.ooi@intel.com>
To:     Richard Cochran <richardcochran@gmail.com>
CC:     Thor Thayer <thor.thayer@linux.intel.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Dalon Westergreen" <dalon.westergreen@linux.intel.com>,
        "Tan, Ley Foon" <ley.foon.tan@intel.com>,
        "See, Chin Liang" <chin.liang.see@intel.com>,
        "Nguyen, Dinh" <dinh.nguyen@intel.com>,
        "Westergreen, Dalon" <dalon.westergreen@intel.com>
Subject: RE: [PATCH v5 08/10] net: eth: altera: add support for ptp and
 timestamping
Thread-Topic: [PATCH v5 08/10] net: eth: altera: add support for ptp and
 timestamping
Thread-Index: AQHWY/e4YIJGgs2mJEi89yZpMyL1/6kbfLeAgBDcXzA=
Date:   Fri, 7 Aug 2020 08:00:13 +0000
Message-ID: <BN6PR11MB1250796D57A7F596F57EC0A3F2490@BN6PR11MB1250.namprd11.prod.outlook.com>
References: <20200727092157.115937-1-joyce.ooi@intel.com>
 <20200727092157.115937-9-joyce.ooi@intel.com> <20200727142925.GB16836@hoboy>
In-Reply-To: <20200727142925.GB16836@hoboy>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a2bad049-9531-4a86-e75a-08d83aa7ea5c
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2020 08:00:13.8281
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KwuUVHMkuyvXPQeE3T6XhcwghTrerlLsPjL0nI8jS8ZceAfSrNXYfVom7/7BnTk0DPlvamxssgXxcTEaTs4kSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB0020
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Richard Cochran <richardcochran@gmail.com>
> Sent: Monday, July 27, 2020 10:29 PM
> To: Ooi, Joyce <joyce.ooi@intel.com>
> Cc: Thor Thayer <thor.thayer@linux.intel.com>; David S . Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Dalon Westergreen
> <dalon.westergreen@linux.intel.com>; Tan, Ley Foon
> <ley.foon.tan@intel.com>; See, Chin Liang <chin.liang.see@intel.com>;
> Nguyen, Dinh <dinh.nguyen@intel.com>; Westergreen, Dalon
> <dalon.westergreen@intel.com>
> Subject: Re: [PATCH v5 08/10] net: eth: altera: add support for ptp and
> timestamping
>=20
> On Mon, Jul 27, 2020 at 05:21:55PM +0800, Ooi, Joyce wrote:
>=20
> > +/* ioctl to configure timestamping */ static int tse_do_ioctl(struct
> > +net_device *dev, struct ifreq *ifr, int cmd) {
> > +	struct altera_tse_private *priv =3D netdev_priv(dev);
> > +	struct hwtstamp_config config;
> > +
> > +	if (!netif_running(dev))
> > +		return -EINVAL;
> > +
> > +	if (!priv->has_ptp) {
> > +		netdev_alert(priv->dev, "Timestamping not supported");
> > +		return -EOPNOTSUPP;
> > +	}
>=20
> The user might well have a PHY that supports time stamping.  The code mus=
t
> pass the ioctl through to the PHY even when !priv->has_ptp.
Ok, I'll remove 'return -EOPNOTSUPP;' to allow those that have PHY with tim=
estamping support to go pass through ioctl.

>
> > +
> > +	if (!dev->phydev)
> > +		return -EINVAL;
> > +
> > +	if (!phy_has_hwtstamp(dev->phydev)) {
> > +		if (cmd =3D=3D SIOCSHWTSTAMP) {
> > +			if (copy_from_user(&config, ifr->ifr_data,
> > +					   sizeof(struct hwtstamp_config)))
> > +				return -EFAULT;
> > +
> > +			if (config.flags)
> > +				return -EINVAL;
> > +
> > +			switch (config.tx_type) {
> > +			case HWTSTAMP_TX_OFF:
> > +				priv->hwts_tx_en =3D 0;
> > +				break;
> > +			case HWTSTAMP_TX_ON:
> > +				priv->hwts_tx_en =3D 1;
> > +				break;
> > +			default:
> > +				return -ERANGE;
> > +			}
> > +
> > +			switch (config.rx_filter) {
> > +			case HWTSTAMP_FILTER_NONE:
> > +				priv->hwts_rx_en =3D 0;
> > +				config.rx_filter =3D HWTSTAMP_FILTER_NONE;
> > +				break;
> > +			default:
> > +				priv->hwts_rx_en =3D 1;
> > +				config.rx_filter =3D HWTSTAMP_FILTER_ALL;
> > +				break;
> > +			}
> > +
> > +			if (copy_to_user(ifr->ifr_data, &config,
> > +					 sizeof(struct hwtstamp_config)))
> > +				return -EFAULT;
> > +			else
> > +				return 0;
> > +		}
> > +
> > +		if (cmd =3D=3D SIOCGHWTSTAMP) {
> > +			config.flags =3D 0;
> > +
> > +			if (priv->hwts_tx_en)
> > +				config.tx_type =3D HWTSTAMP_TX_ON;
> > +			else
> > +				config.tx_type =3D HWTSTAMP_TX_OFF;
> > +
> > +			if (priv->hwts_rx_en)
> > +				config.rx_filter =3D HWTSTAMP_FILTER_ALL;
> > +			else
> > +				config.rx_filter =3D HWTSTAMP_FILTER_NONE;
> > +
> > +			if (copy_to_user(ifr->ifr_data, &config,
> > +					 sizeof(struct hwtstamp_config)))
> > +				return -EFAULT;
> > +			else
> > +				return 0;
> > +		}
> > +	}
> > +
> > +	return phy_mii_ioctl(dev->phydev, ifr, cmd); }
>=20
> Thanks,
> Richard