Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750790AbWEOXiM (ORCPT ); Mon, 15 May 2006 19:38:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750795AbWEOXiM (ORCPT ); Mon, 15 May 2006 19:38:12 -0400 Received: from smtp.osdl.org ([65.172.181.4]:7658 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750790AbWEOXiK (ORCPT ); Mon, 15 May 2006 19:38:10 -0400 Date: Mon, 15 May 2006 16:37:40 -0700 (PDT) From: Linus Torvalds To: Alan Cox cc: Russell King , Andrew Morton , Andreas Mohr , florin@iucha.net, linux-kernel@vger.kernel.org, linux@dominikbrodowski.net Subject: Re: pcmcia oops on 2.6.17-rc[12] In-Reply-To: <1147734026.26686.200.camel@localhost.localdomain> Message-ID: References: <20060423192251.GD8896@iucha.net> <20060423150206.546b7483.akpm@osdl.org> <20060508145609.GA3983@rhlx01.fht-esslingen.de> <20060508084301.5025b25d.akpm@osdl.org> <20060508163453.GB19040@flint.arm.linux.org.uk> <1147730828.26686.165.camel@localhost.localdomain> <1147734026.26686.200.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1230 Lines: 29 On Tue, 16 May 2006, Alan Cox wrote: > > It would certainly be a lot cleaner than this sort of code in the pcmcia > core right now. Want me to send a patch which only allows for SA_SHIRQ > and WARN_ON()'s for any driver not asking for shared IRQ ? I think it's too late for that in the current series, but yes, we could do it for 2.6.18. There are a few valid reasons for not using SA_SHIRQ, but they tend to be really special. Ie you'd better _know_ that you're either some system device, or you're physically in an ISA slot, not just based on some old ISA design. And PCMCIA is no longer an excuse, exactly because of some systems that will route even the 16-bit interrupts through a PCI irq. So anything in arch/ is likely ok (for example, the vm86 interrupt handling on x86 had _better_ be an exclusive interrupt ;) Doing a quick grep shows a surprising amount of drivers that pass in zero, but I guess that they truly _are_ old ISA sound/networking drivers. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/