Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: [PATCH 1/1] arm64: add support for PAGE_SIZE aligned kernel
 stack
Reply-To: maninder1.s@samsung.com
From:   Maninder Singh <maninder1.s@samsung.com>
To:     Vaneet Narang <v.narang@samsung.com>,
        Mark Rutland <mark.rutland@arm.com>
CC:     "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will@kernel.org" <will@kernel.org>,
        "oleg@redhat.com" <oleg@redhat.com>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "adobriyan@gmail.com" <adobriyan@gmail.com>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "steve.capper@arm.com" <steve.capper@arm.com>,
        "vincenzo.frascino@arm.com" <vincenzo.frascino@arm.com>,
        "anshuman.khandual@arm.com" <anshuman.khandual@arm.com>,
        "ardb@kernel.org" <ardb@kernel.org>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "maz@kernel.org" <maz@kernel.org>,
        "kristina.martsenko@arm.com" <kristina.martsenko@arm.com>,
        "samitolvanen@google.com" <samitolvanen@google.com>,
        "ebiederm@xmission.com" <ebiederm@xmission.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "gladkov.alexey@gmail.com" <gladkov.alexey@gmail.com>,
        "daniel.m.jordan@oracle.com" <daniel.m.jordan@oracle.com>,
        "walken@google.com" <walken@google.com>,
        "bernd.edlinger@hotmail.de" <bernd.edlinger@hotmail.de>,
        "laoar.shao@gmail.com" <laoar.shao@gmail.com>,
        "avagin@gmail.com" <avagin@gmail.com>,
        "john.johansen@canonical.com" <john.johansen@canonical.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        AMIT SAHRAWAT <a.sahrawat@samsung.com>
In-Reply-To: <20200804061526epcms5p3ff393f7e51d28ed896105c868bd31e5b@epcms5p3>
Message-ID: <20200807111720epcms5p1206fe967bcee6136774c8432ed5b514b@epcms5p1>
Date:   Fri, 07 Aug 2020 16:47:20 +0530
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <20200804061526epcms5p3ff393f7e51d28ed896105c868bd31e5b@epcms5p3>
        <20200803123447.GA89825@C02TD0UTHF1T.local>
        <1596386115-47228-1-git-send-email-maninder1.s@samsung.com>
        <CGME20200802165825epcas5p3a2127be681530fdd785db0f8961eaf96@epcms5p1>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Mark, 

>>If you are seeing issues with the current stack size, can you please
>>explain that in more detail? Where are you seeing problems? Which
>>configuration options do you have selected?
>>

We checked on our system with netflix and youtube 4K videos running
max stack consumption was 7 KB:

sh-3.2# cat /sys/kernel/debug/tracing/stack_max_size  
7312

Thus we thought 16KB wil waste a lot of memory for our ARM64 target,
and 8KB can be less in some exceptional case.
So we decided for 12 KB change.


>>I'm not keen on making kernel stack sizes configurable as it's not
>>currently possible for the person building the kernel to figure out a
>>safe size (and if this were possible, it's be better to handle this
>>automatically).
>>

Ok, can we do something else?, like not making it configurable,
but do code changes to support it for PAGE_SIZE aligned stacks
rather than power of 2 alignement.

Although with configurable also, it depends on VMAP stack,
so user will have stack exhaust  exception and can increase acccordingly also.

> 
>Motivation behind these changes is saving memory on our system. 
>Our system runs around 2500 threads concurrently so saving 4Kb  
>might help us in saving 10MB memory.
> 
>To ensure 12KB is sufficient for our system we have used stack tracing and 
>realised maximum stack used is not more than 9KB. 
> /sys/kernel/tracing/stack_max_size
> 
>Tracing interface defined by kernel to track maximum stack size can be used
>by others to decide appropriate stack size.
> 

Thanks