Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2165825pxa; Fri, 7 Aug 2020 04:58:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGhPaFPsQm2vf/XydFQ+CqaLcdPkhTWaR0QArwb4V1zpTq5IVUmq/ikK2jVQo3Jet6m1Xg X-Received: by 2002:a17:906:46c6:: with SMTP id k6mr8382458ejs.230.1596801522893; Fri, 07 Aug 2020 04:58:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596801522; cv=none; d=google.com; s=arc-20160816; b=H1sE9gGp3nqpSb3x24P0h6/i5lJAgRhbZJvKKnhYqr5Y8s3GY3chLGIfE2ROgcyLcu DsIdGgaBhRQgqxTKtHxSSGd3oBVba0FI7cgpQqhG8e8D/xmunoaOpU9y5Dcq4/zCqL2K Cex/XATxXJwlCP5xgYnABCn7WTY6YbVUIU3C8DM81ZJtXnKEaiG5vaCG5MCIJXtQBprX Lpz61xyfxwer/YQRwLoDyS1s8TBg3/HjgRSKPV0Agiemx0aXmiRLfhCeHvQHB2RNfOuk tmIK3kSsZFhWwCPGKFPxZQG2SIbcrzk9vwQCTiXKu8mxOJzeGJ5JNvsfLN11IpFJWnA3 cPOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=4OTRM6GItp3LnFcS/b/Uhe1XhDIzGwsKYalbI9Dy4T8=; b=S0Y8C3gAKYR9yxU9chT0mQ84iGrs419lLDv21bLUIvaMOJKrMev3znwcLvWlMULDd+ RLYBso4Vim4ERa6LiCQX1dluKJAcPRx8mRO/jauchvdz7hLUCt/z88iu9kniNEFYjNIy 6Gv3U/vvazlJ8OW3WJgC3y1xmzjy3MG/rFdcuhC+ovvKJaSCBiRwGvEZMigbTYnnODnd hNJUADuOMg3SPGtohasE2lPNeMsSjClyT1Z0uqJuNXyPVsKCPvGyK5mbxc9RufZtbQZz 9Ni56C/K+IKdfcJie4dFjotDb8uQT6BWZKpwHmYOY704zSmbTZeeQe42f+xxiVdiVrmT xBHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZezYuoq9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si5097355edc.157.2020.08.07.04.58.19; Fri, 07 Aug 2020 04:58:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZezYuoq9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728331AbgHGL5P (ORCPT + 99 others); Fri, 7 Aug 2020 07:57:15 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:38620 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726293AbgHGL5O (ORCPT ); Fri, 7 Aug 2020 07:57:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596801434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4OTRM6GItp3LnFcS/b/Uhe1XhDIzGwsKYalbI9Dy4T8=; b=ZezYuoq9ZkHjuM3ephqLWOo/GvHjsH1YFIrF1Y5mg8Z8GaQrBubx1C9/nBSdSAuJ/tJRad zJrEOzZcN7r8IRkj8ExxS6oqyfZLa/NvsOv4pvX6OGfe9zczzpxUmcaZNzAa+uFWNJ7+ZJ wW8+p0F7ouUUHpBCXBUJJyvpCbvW+wA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-x7C4o9zANwWgQB1b1vy1gw-1; Fri, 07 Aug 2020 07:57:10 -0400 X-MC-Unique: x7C4o9zANwWgQB1b1vy1gw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85A3880BCB2; Fri, 7 Aug 2020 11:57:07 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-195.ams2.redhat.com [10.36.112.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC92F87A7A; Fri, 7 Aug 2020 11:57:05 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id BEDD7B1A; Fri, 7 Aug 2020 13:57:04 +0200 (CEST) Date: Fri, 7 Aug 2020 13:57:04 +0200 From: Gerd Hoffmann To: Xin He Cc: daniel@ffwll.ch, airlied@linux.ie, sumit.semwal@linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Qi Liu , Muchun Song Subject: Re: [PATCH v3] drm/virtio: fix missing dma_fence_put() in virtio_gpu_execbuffer_ioctl() Message-ID: <20200807115704.4epnok7vxwdmemns@sirius.home.kraxel.org> References: <20200721101647.42653-1-hexin.op@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721101647.42653-1-hexin.op@bytedance.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 06:16:47PM +0800, Xin He wrote: > From: Qi Liu > > We should put the reference count of the fence after calling > virtio_gpu_cmd_submit(). So add the missing dma_fence_put(). > virtio_gpu_cmd_submit(vgdev, buf, exbuf->size, > vfpriv->ctx_id, buflist, out_fence); > + dma_fence_put(&out_fence->f); > virtio_gpu_notify(vgdev); Pushed to drm-misc-fixes. thanks, Gerd