Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2198358pxa;
        Fri, 7 Aug 2020 05:46:50 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJza/u4MAExGRfCWr+EFQU8xRq17wl7nUmIZRcig5M26GxPnbCS3gKwnkam5pBOFp9zxo2UP
X-Received: by 2002:a17:906:5f8a:: with SMTP id a10mr9379485eju.379.1596804409769;
        Fri, 07 Aug 2020 05:46:49 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1596804409; cv=none;
        d=google.com; s=arc-20160816;
        b=zejKDhgMxUM8er2UgSS4Fsb/yjbAAzhm7KSve5kporo/SLvjoaiCC8C6hAwkdoO3We
         oHs3sgWB/kPo1trd3GlsOyhU1kIVCA2RwzKE5JrIRPL+0yAaHoSzVY5q3uC7xfY8KZBc
         0ceyLMsDqAhaDFQmjQC45OnC9e730JDlr3G/zOHmArkZWydM9p84iVHnGm/eOvFVvG4S
         L/nqVWyl/xZciw43WpkIzDxRQe0L4lM6SeXAW+vl40k5IYGyS//nXb66lNYDWHYOMLAl
         ZPANH3NCMRZ2vf9vHllOgbc4lR+QbEilXLK+L6bFN0Ky0U7+NrCufdtFeyEhTioDP3BN
         6mxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=273fiZa3j2YUsHYvjEo3xvFBeJLIY7mZ32ur6GZf0EM=;
        b=b2D0wjeEAjGb6qZmcg5kJEKaMJ8l6Z8xjLzT+Q52cocdS1rrZ6aDU7/towOexX/mKL
         svm0yI+ExVQRtLFHKzdkqZlKK1iRjvkhdvKSqjCnlG1r7oepTQy9pnqlIlU7IIaU2Iz2
         UR0Vj8WoscDLTXIAGOmxxamRojin8crrInEh/Lj8fALffiB1LYp/cXO2XukVLpHv6gjZ
         Kd4HPbyFgFnLjsG0/PRtMuTRvYNLi+8tOi3Pv64oHMWVEOUnxok9IfQQZzVFOH36LySj
         /M8H+EkMByooac7+TTeayajk7mVUmnPQOfcrg2XTMI7s9DJ5GCFXWjOPO3lcOtqN8qTn
         6S+A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QVwW8wID;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id v14si5527601ejx.388.2020.08.07.05.46.25;
        Fri, 07 Aug 2020 05:46:49 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QVwW8wID;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728423AbgHGMnR (ORCPT <rfc822;chenl.lei@gmail.com> + 99 others);
        Fri, 7 Aug 2020 08:43:17 -0400
Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50559 "EHLO
        us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1728350AbgHGMnQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Aug 2020 08:43:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
        s=mimecast20190719; t=1596804195;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=273fiZa3j2YUsHYvjEo3xvFBeJLIY7mZ32ur6GZf0EM=;
        b=QVwW8wIDIa1aK18bgE0wv6MXTdWGITG4t87itufgubLiU4N8nT5UlKy68dffxcZscFKngp
        6+SGR/SiO+K8nYE36PggEtI/DYrfkY8Nu3P5KDjFcJTgWIGUSiQC4N5pQ32JSJg+HX0Z7x
        nuJL5yKJF8u3O3h2hiVQpkImdRUWPwU=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-32-8ExUZS9hO7iDqC6bCcjDtg-1; Fri, 07 Aug 2020 08:43:14 -0400
X-MC-Unique: 8ExUZS9hO7iDqC6bCcjDtg-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
        (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
        (No client certificate requested)
        by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 549B718A1DFB;
        Fri,  7 Aug 2020 12:43:12 +0000 (UTC)
Received: from sirius.home.kraxel.org (ovpn-112-195.ams2.redhat.com [10.36.112.195])
        by smtp.corp.redhat.com (Postfix) with ESMTP id E9E377B932;
        Fri,  7 Aug 2020 12:43:11 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
        id 001E99CBC; Fri,  7 Aug 2020 14:43:10 +0200 (CEST)
Date:   Fri, 7 Aug 2020 14:43:10 +0200
From:   Gerd Hoffmann <kraxel@redhat.com>
To:     Xin He <hexin.op@bytedance.com>
Cc:     airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, Qi Liu <liuqi.16@bytedance.com>
Subject: Re: [PATCH] drm/virtio: fix memory leak in
 virtio_gpu_cleanup_object()
Message-ID: <20200807124310.cmhbj6bj76twdtaw@sirius.home.kraxel.org>
References: <20200722051851.72662-1-hexin.op@bytedance.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200722051851.72662-1-hexin.op@bytedance.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 22, 2020 at 01:18:51PM +0800, Xin He wrote:
> Before setting shmem->pages to NULL, kfree() should
> be called.

>  			sg_free_table(shmem->pages);
> +			kfree(shmem->pages);
>  			shmem->pages = NULL;

Pushed to drm-misc-fixes.

thanks,
  Gerd