Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com>
To:     Thirumalesha Narasimhappa <nthirumalesha7@gmail.com>
CC:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Boris Brezillon <boris.brezillon@collabora.com>,
        Chuanhong Guo <gch981213@gmail.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH] mtd: spinand: micron: add support for
 MT29F2G01AAAED
Thread-Topic: [EXT] [PATCH] mtd: spinand: micron: add support for
 MT29F2G01AAAED
Thread-Index: AQHWWFRx8s+IuQkuokuJBjx7DXXxrKkszj/A
Date:   Fri, 7 Aug 2020 13:41:56 +0000
Message-ID: <MN2PR08MB6397250EBF7AB4BE26938C30B8490@MN2PR08MB6397.namprd08.prod.outlook.com>
References: <20200712135942.10904-1-nthirumalesha7@gmail.com>
In-Reply-To: <20200712135942.10904-1-nthirumalesha7@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 78c3ad11-6286-45eb-8d42-08d83ad7a6e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2020 13:41:56.3584
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f38a5ecd-2813-4862-b11b-ac1d563c806f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TOj1z1bCCk/2dXFFI7L44ZLwYpd/jOzA/fzDQw/xlm42YPx/oFv93n+/oH8X4NT3zfwa2V15wZxdboak8kTNcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR08MB5377
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Thirumalesha,

>=20
> The MT29F2G01AAAED is a single die, 2Gb Micron SPI NAND Flash with 4-bit
> ECC
>=20
> Signed-off-by: Thirumalesha Narasimhappa <nthirumalesha7@gmail.com>
> ---
>  drivers/mtd/nand/spi/micron.c | 77 +++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
>=20
> diff --git a/drivers/mtd/nand/spi/micron.c b/drivers/mtd/nand/spi/micron.=
c
> index 5d370cfcdaaa..7e0b61d7b90f 100644
> --- a/drivers/mtd/nand/spi/micron.c
> +++ b/drivers/mtd/nand/spi/micron.c
> @@ -17,6 +17,7 @@
>  #define MICRON_STATUS_ECC_1TO3_BITFLIPS	(1 << 4)
>  #define MICRON_STATUS_ECC_4TO6_BITFLIPS	(3 << 4)
>  #define MICRON_STATUS_ECC_7TO8_BITFLIPS	(5 << 4)

It is better to add comment here, like

/* For Micron  MT29F2G01AAAED Device */

> +#define MICRON_STATUS_ECC_1TO4_BITFLIPS	(1 << 4)
>=20
>  #define MICRON_CFG_CR			BIT(0)
>=20
> @@ -44,6 +45,19 @@ static SPINAND_OP_VARIANTS(update_cache_variants,
>  		SPINAND_PROG_LOAD_X4(false, 0, NULL, 0),
>  		SPINAND_PROG_LOAD(false, 0, NULL, 0));
>=20
> +/* Micron  MT29F2G01AAAED Device */
> +static SPINAND_OP_VARIANTS(read_cache_variants_mt29f2g01aaaed,
> +		SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0),
> +		SPINAND_PAGE_READ_FROM_CACHE_X2_OP(0, 1, NULL, 0),
> +		SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0),
> +		SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0));
> +
> +static SPINAND_OP_VARIANTS(write_cache_variants_mt29f2g01aaaed,
> +		SPINAND_PROG_LOAD(true, 0, NULL, 0));
> +
> +static SPINAND_OP_VARIANTS(update_cache_variants_mt29f2g01aaaed,
> +		SPINAND_PROG_LOAD(false, 0, NULL, 0));
> +
>  static int micron_8_ooblayout_ecc(struct mtd_info *mtd, int section,
>  				  struct mtd_oob_region *region)
>  {
> @@ -69,11 +83,41 @@ static int micron_8_ooblayout_free(struct mtd_info
> *mtd, int section,
>  	return 0;
>  }
>=20
> +static int mt29f2g01aaaed_ooblayout_ecc(struct mtd_info *mtd, int sectio=
n,
> +					struct mtd_oob_region *region)
> +{
> +	if (section >=3D 4)
> +		return -ERANGE;
> +
> +	region->offset =3D (section * 16) + 8;
> +	region->length =3D 8;
> +
> +	return 0;
> +}
> +
> +static int mt29f2g01aaaed_ooblayout_free(struct mtd_info *mtd, int secti=
on,
> +					 struct mtd_oob_region *region)
> +{
> +	if (section >=3D 4)
> +		return -ERANGE;
> +
> +	/* Reserve 2 bytes for the BBM. */
> +	region->offset =3D (section * 16) + 2;
> +	region->length =3D 6;
> +
> +	return 0;
> +}
> +
>  static const struct mtd_ooblayout_ops micron_8_ooblayout =3D {
>  	.ecc =3D micron_8_ooblayout_ecc,
>  	.free =3D micron_8_ooblayout_free,
>  };
>=20
> +static const struct mtd_ooblayout_ops mt29f2g01aaaed_ooblayout =3D {
> +	.ecc =3D mt29f2g01aaaed_ooblayout_ecc,
> +	.free =3D mt29f2g01aaaed_ooblayout_free,
> +};
> +
>  static int micron_select_target(struct spinand_device *spinand,
>  				unsigned int target)
>  {
> @@ -114,6 +158,27 @@ static int micron_8_ecc_get_status(struct
> spinand_device *spinand,
>  	return -EINVAL;
>  }
>=20
> +static int mt29f2g01aaaed_ecc_get_status(struct spinand_device *spinand,
> +					 u8 status)
> +{
> +	switch (status & MICRON_STATUS_ECC_MASK) {
> +	case STATUS_ECC_NO_BITFLIPS:
> +		return 0;
> +
> +	case STATUS_ECC_UNCOR_ERROR:
> +		return -EBADMSG;
> +
> +	/* 1 to 4-bit error detected and corrected */
> +	case MICRON_STATUS_ECC_1TO4_BITFLIPS:
> +		return 4;
> +
> +	default:
> +		break;
> +	}
> +
> +	return -EINVAL;
> +}
> +
>  static const struct spinand_info micron_spinand_table[] =3D {
>  	/* M79A 2Gb 3.3V */
>  	SPINAND_INFO("MT29F2G01ABAGD",
> @@ -217,6 +282,18 @@ static const struct spinand_info
> micron_spinand_table[] =3D {
>  		     SPINAND_ECCINFO(&micron_8_ooblayout,
>  				     micron_8_ecc_get_status),
>  		     SPINAND_SELECT_TARGET(micron_select_target)),
> +	/* M70A 2Gb 3.3V */

This should be M69A.

> +	SPINAND_INFO("MT29F2G01AAAED",
> +
> SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x9F),
> +		     NAND_MEMORG(1, 2048, 256, 64, 2048, 80, 2, 1, 1),
> +		     NAND_ECCREQ(4, 512),
> +
> SPINAND_INFO_OP_VARIANTS(&read_cache_variants_mt29f2g01aaaed,
> +
> &write_cache_variants_mt29f2g01aaaed,
> +
> &update_cache_variants_mt29f2g01aaaed),
> +		     0,
> +		     SPINAND_ECCINFO(&mt29f2g01aaaed_ooblayout,
> +				     mt29f2g01aaaed_ecc_get_status),
> +		     SPINAND_SELECT_TARGET(micron_select_target)),

This device doesn't have multiple targets, you can remove micron_select_tar=
get.

>  };
>=20
>  static int micron_spinand_init(struct spinand_device *spinand)
> --
> 2.17.1

Thanks,
Shiva