Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2268400pxa; Fri, 7 Aug 2020 07:18:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxl8Lb6uF/NmpU/3ocsu1kiuhwpCNNBCMvv1xsmPB3XUXlwoRRiHiDVi67tjWkLYmtmM5ID X-Received: by 2002:a50:9316:: with SMTP id m22mr9391054eda.178.1596809933436; Fri, 07 Aug 2020 07:18:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596809933; cv=none; d=google.com; s=arc-20160816; b=uTGllaX0LCGd75AhaiqHnqp6ZY89JHfiROajROtqqoDLyeTDTWBQPPV7bJYnHLXcLj YNR7BpmyFDyJFpgBNHZVeF1TY9sDrq2qf1Yg06/c57kefTmykhnC1aKRG81ZqVz6+CGp o2cVAlcR0iwm+Y7RLcjVzZa9GC1ZYNSbyG/DnodDwqzH4QryumpeZV7/T8CEEQ1762B4 ZP8Pk/eQYUPRxYPj9GoNpnG0h2maAhjwMhNqdPdKdrHmucp9JAv8ecYsLhjErMPO+zmu LXpMkATYj6KnU4kEU5rk7DrACLI1bbdaRVUf4nbebd8ifbjPpmXI3ZFE77jC4rB84WMJ dsVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=05Fah/8fCEe40F4vDLO47ODrHHtF5Yi7ZhltLP/Qm5M=; b=qW3NZyN4aFByYMDNi5i6pbuNn6Qr1dAbJKBuZoJEY8hHDScrpYbUzGrcf7bFyzU/Ad Sm68lQ0wxOe8PZtJSjOUUyumccipDBJpvps93iQ4UWuht4CLG5DkcGxpXQAXuD120FYD /hWBUgSWssEdhe1FblN96PYVF6N+6panlymQi4GSD25p0CVbJSH5BGMpfNwYxW9tFdf3 RfhVmg0ftJ5Lu2RXLpy/pddn2TnqFHySQ0Nn3aTc8PLhZNa424+16BW2lZUWsClBAA19 0pJxczTB39RPw9VA2vpoSZZAiHJp2hOqfTMnU7fmYCIqNzjlv85HDSJpSh3LjNokdgiN 73+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx25si5101428edb.149.2020.08.07.07.18.29; Fri, 07 Aug 2020 07:18:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726533AbgHGORw (ORCPT + 99 others); Fri, 7 Aug 2020 10:17:52 -0400 Received: from www262.sakura.ne.jp ([202.181.97.72]:57064 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgHGORv (ORCPT ); Fri, 7 Aug 2020 10:17:51 -0400 Received: from fsav106.sakura.ne.jp (fsav106.sakura.ne.jp [27.133.134.233]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 077EHd51023810; Fri, 7 Aug 2020 23:17:39 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav106.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav106.sakura.ne.jp); Fri, 07 Aug 2020 23:17:39 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav106.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 077EHdl2023806 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 7 Aug 2020 23:17:39 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: splice: infinite busy loop lockup bug To: Ming Lei , Al Viro Cc: syzkaller-bugs@googlegroups.com, syzbot , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <00000000000084b59f05abe928ee@google.com> <29de15ff-15e9-5c52-cf87-e0ebdfa1a001@I-love.SAKURA.ne.jp> <20200807122727.GR1236603@ZenIV.linux.org.uk> <20200807123854.GS1236603@ZenIV.linux.org.uk> <20200807134114.GA2114050@T590> From: Tetsuo Handa Message-ID: Date: Fri, 7 Aug 2020 23:17:32 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200807134114.GA2114050@T590> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/08/07 22:41, Ming Lei wrote: >> FWIW, my preference would be to have for_each_bvec() advance past zero-length >> segments; I'll need to go through its uses elsewhere in the tree first, though >> (after I grab some sleep), > > Usually block layer doesn't allow/support zero bvec, however we can make > for_each_bvec() to support it only. > > Tetsuo, can you try the following patch? Yes, this patch solves the lockup. Thank you.