Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 7 Aug 2020 17:05:26 +0200
From:   Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To:     Gao Xiang <hsiangkao@aol.com>
Cc:     kernel test robot <lkp@intel.com>, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: fs/erofs/zdata.c:198:22: sparse: sparse: non size-preserving
 integer to pointer cast
Message-ID: <20200807150526.vkbkslhiyy7gb6dc@ltop.local>
References: <202008072005.Myrby1lg%lkp@intel.com>
 <20200807144801.GA30258@hsiangkao-HP-ZHAN-66-Pro-G1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200807144801.GA30258@hsiangkao-HP-ZHAN-66-Pro-G1>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 07, 2020 at 10:48:12PM +0800, Gao Xiang wrote:
> On Fri, Aug 07, 2020 at 08:08:10PM +0800, kernel test robot wrote:
> > sparse warnings: (new ones prefixed by >>)
> > 
> > >> fs/erofs/zdata.c:198:22: sparse: sparse: non size-preserving integer to pointer cast
> >    fs/erofs/zdata.c:282:22: sparse: sparse: non size-preserving integer to pointer cast
> >    fs/erofs/zdata.c:1094:24: sparse: sparse: non size-preserving integer to pointer cast
> 
> I don't think these are valid warnings.

Indeed, they're not.
 
> All these three lines are using cmpxchg struct page * (which is equivalent to unsigned long
> in these cmpxchg macros) and nothing special at all in my opinion (Especially the last two
> lines).

What is special is that s390 use __sync_val_compare_and_swap() to implement
cmpxchg(). This builtin has a return type which depends on its arguments
while sparse was always using 'int' as the return type.

A patch is on the way.

Regards,
-- Luc Van Oostenryck