Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750980AbWEPBVE (ORCPT ); Mon, 15 May 2006 21:21:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750982AbWEPBVE (ORCPT ); Mon, 15 May 2006 21:21:04 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:57355 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S1750970AbWEPBVC (ORCPT ); Mon, 15 May 2006 21:21:02 -0400 Date: Tue, 16 May 2006 11:20:46 +1000 To: Patrick McHardy Cc: "David S. Miller" , shemminger@osdl.org, ranjitm@google.com, akpm@osdl.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] tcpdump may trace some outbound packets twice. Message-ID: <20060516012045.GA13574@gondor.apana.org.au> References: <44692847.4080100@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44692847.4080100@trash.net> User-Agent: Mutt/1.5.9i From: Herbert Xu Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 789 Lines: 21 On Tue, May 16, 2006 at 03:17:59AM +0200, Patrick McHardy wrote: > > 3) Clone the skb and have dev_queue_xmit_nit() consume it. > > That should actually be pretty easy. Unfortunately that would mean an unconditional copy for all TSO packets on NICs such as tg3/e1000. These drivers have to modify the data area of the skb. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/