Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200614063619.44944-1-navid.emamdoost@gmail.com>
In-Reply-To: <20200614063619.44944-1-navid.emamdoost@gmail.com>
From:   Rob Herring <robh@kernel.org>
Date:   Fri, 7 Aug 2020 10:41:43 -0600
Message-ID: <CAL_JsqKvrKU6RScJSsHFNn7GHx0N9XCdZmNupRGDqg4h0UKV9w@mail.gmail.com>
Subject: Re: [PATCH] drm/panfrost: perfcnt: fix ref count leak in panfrost_perfcnt_enable_locked
To:     Navid Emamdoost <navid.emamdoost@gmail.com>
Cc:     Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Steven Price <steven.price@arm.com>,
        Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Navid Emamdoost <emamd001@umn.edu>, wu000273@umn.edu,
        kjlu@umn.edu, mccamant@cs.umn.edu
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jun 14, 2020 at 12:36 AM Navid Emamdoost
<navid.emamdoost@gmail.com> wrote:
>
> in panfrost_perfcnt_enable_locked, pm_runtime_get_sync is called which
> increments the counter even in case of failure, leading to incorrect
> ref count. In case of failure, decrement the ref count before returning.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

Applied.

Rob