Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2497706pxa; Fri, 7 Aug 2020 12:37:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIMgSHL6akuzsvT3L+LEXwhM3RNl9nTi8tgFHme6imsjpofviz56cyUek96ETlCbJrZtC3 X-Received: by 2002:a17:906:2e0a:: with SMTP id n10mr11294950eji.18.1596829026203; Fri, 07 Aug 2020 12:37:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596829026; cv=none; d=google.com; s=arc-20160816; b=CPuSexuPyrUh9sy30Z53q7EoMoq7H4n0VlriMaFReUkB84EOqx42Gz+RVZ6DhBa1OM Vu9FzDjIfnmTuB0Ng9Tehoy6lFGZS9yP/epc1P14XxwrD5sNqvY4XB+8NXqsRF8b6Qld xl0ziUzZ+67OtH1J++2wD+n1ZPb449VnipR8glHZe6OCAo0ZOecBAVaRBk8J8/y4jS/u IQSq/RRrj23L1fQ4030C1EEJZfywU1KBx9VLlq9bIsTRV9h0RG+yU/R2enp5hov2r3cA Q8yaXbXDeSoYZuX3QXCSFUS/+u0CcfQLKJBsBHpJJKzoO8KHjSTEhAZfYrSbyWcLPeuu pEQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:cc:to:from:date:user-agent :message-id:dkim-signature; bh=8B3vcTdKxdTXdjxQQXeqQU3fplBogydFUAU3MnPnOKc=; b=k/v6XzKodUqbJlu02PoEUJPfVbHwxf6boKeiAxinpMrwUcWygHhKs9Rja2Pc/QNQXG ShBYtfraYzuKrHTVwRkEHerlCPLVUgtqkTDH5RWzno7m3kPQ9/e0af7hxdUGYVqBySUo /70pSn6DOGFmEwlEMLFof3TYIHykKRhN1j8c3j5BfcU6sz6vyQNBU8GeMzBEKUEp7d4X FAaHTDhRuilYkigBWJfOODLQGs82zAz/XSnTHh5TwZJnIoY8xZe9yI9djc1JAWzQllYG Lz1T0NVjLls3BuGB+Goz3Y2cLMMKhSzsb1YIFM6dTcshDRrd7LxMJbjVC/VeMoFBPUvY LC4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=LicXS2JV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si1181030ejq.375.2020.08.07.12.36.43; Fri, 07 Aug 2020 12:37:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=LicXS2JV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726242AbgHGTe3 (ORCPT + 99 others); Fri, 7 Aug 2020 15:34:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726045AbgHGTe3 (ORCPT ); Fri, 7 Aug 2020 15:34:29 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23335C061756 for ; Fri, 7 Aug 2020 12:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Subject:Cc:To:From:Date:Message-ID: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To:References; bh=8B3vcTdKxdTXdjxQQXeqQU3fplBogydFUAU3MnPnOKc=; b=LicXS2JVVk1dhQl0sH6K5VlxAp o5+KoHy6yMO8JIXAd75BKyo3Sp5U4rxtTDWVkFCPzh33RQ/0g5az/c67YPZLKDuTn9zVEMzHq6e6J 2sXVbiM9x5Nbsc584O0uYEhmGt47+nYo/fgyf+T+7/VhFpzSXMvFdkM9o8GB6zsFH5SdnrY7iuFqI +QrDsT0iYOoXgBk2U4oF508cb39zD9RCkkT/fxJbhUI2/uxJSHEHXkS7/lbTHJVCU3OZc2rZX/xGQ iEWGTvOF4Mwc00S6ZizVw6YZ/4PSSao7Tg8VvR34u3m2lTf8B3Q9tvr1f31micNmWGkaBU9uOsNVP MYiLBwig==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k4889-0005Jc-Ew; Fri, 07 Aug 2020 19:34:17 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 0831D30015A; Fri, 7 Aug 2020 21:34:13 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id A0E4621F9221F; Fri, 7 Aug 2020 21:34:13 +0200 (CEST) Message-ID: <20200807192336.405068898@infradead.org> User-Agent: quilt/0.66 Date: Fri, 07 Aug 2020 21:23:36 +0200 From: Peter Zijlstra To: tglx@linutronix.de, mingo@kernel.org, will@kernel.org Cc: x86@kernel.org, linux-kernel@vger.kernel.org, elver@google.com, paulmck@kernel.org, rostedt@goodmis.org, rjw@rjwysocki.net, peterz@infradead.org Subject: [RFC][PATCH 0/3] Tracing, Idle, RCU and such goodness Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Syzbot report: https://lkml.kernel.org/r/000000000000e3068105ac405407@google.com triggered a whole bunch of fallout. These 3 patches are in reverse order of discovery. With them applied the reproducer no longer triggers and the machine boots without errors. I also spend half the day trying to rewrite TRACE_IRQFLAGS, but so far haven't had success. I have the feeling that there's something slightly simpler hiding in there, but so far it doesn't want to come out. Please, look carefully, this is all tricky code, and it's been a long and hot day here, mistakes are almost guaranteed :/ I also want to remove the _rcuidle() from trace_preemptirq.c, but given this was quite enough, I didn't touch those.