Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2504499pxa; Fri, 7 Aug 2020 12:49:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHZ0RZgaMGk7P3dxN64YJwYgxv8X0HX6abfvPrwaKK1C0HSJYIdgerZRncLmeucItelJRC X-Received: by 2002:aa7:c6ce:: with SMTP id b14mr10848509eds.208.1596829743128; Fri, 07 Aug 2020 12:49:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596829743; cv=none; d=google.com; s=arc-20160816; b=tZrI1ja8KFURGtj0q9F6mfnvajDh5Of1iwaDTO82sRWqFv1N1ppUpn4f+aTrCiI2F8 uNwufX7U5ce7JLMC9MxIwQZQitMCLBkgXF78t4v3JemygIXFZ6f1eA0zm8uI1Zjo3PNK 5lQ7Mp+J12c+OP6ztMnjoAHUPg2fAWPHSYUUg+8Y+T3aG8jsi7GR/h3jEuIfo8f6qeNr qRJQQCBQqrcqFwVF2Gq97fNlGWWwMlJnDBm+Qr210C9O76MBFMrpHbmw0cQrRKFbik68 C/a/cex4wLln7+wfPbwvTqk+FPDgP5k47DirXXcJXgDVmoIup6SdYn9EwcT8O6grpPFl 6FBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RTd8RvTViF9QiZ3UMF3iz+ZRM8V/b763rRq9Je/qhIw=; b=xmtY5j+1VioUmPluhuRnMpvLpy7W9TU9VGVD8+IuPtcVFG23fSR/0zXWHYmeA+K3/G HS2xLUWrqj/s5bFcUJ7cEqLxv9aoSuyuIyoxuHGQHe6PPYH1Uw9abJ3ph2+UIs4Q99WA dsD6lTjElo8aeGzbeqGAWQ/7HEOnQafQp+QQllcO5ncAVNfbXDyeNUndKuEu00+MtsqR eGS/mcRyG1I01B/C5RfcnfMVXTDW+vT4oc1vRmtf/BhLsIO+aEJ0Zc+CuubdPOyGT+7U nRX42hIPeS+EcqhVZyGsDfxoUfvP0AQqdRaXVhPm9JFMWGVNwf+0IWe8s0mk/PkczW35 N+uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZsZVOnU0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w23si5729980edu.32.2020.08.07.12.48.39; Fri, 07 Aug 2020 12:49:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZsZVOnU0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726426AbgHGTrX (ORCPT + 99 others); Fri, 7 Aug 2020 15:47:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:37496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725893AbgHGTrW (ORCPT ); Fri, 7 Aug 2020 15:47:22 -0400 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 630CD22CA1 for ; Fri, 7 Aug 2020 19:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596829642; bh=3J6m0L2M1H6OYUCNqt6X/ozt7tphzFWFRd3BR+Q4sdE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZsZVOnU0pSYlXCiknGgpzZ+yoJggEaZQgAobS6FE23rUVqN6a8RbLV9/R4gY80skh l2n9eHAw4Outhaghsb5o7cqPeB7bhMxJ1pXv2nojezu/Hu779bT/VAplrQWS2bVnPb 5oQHwGBk8XQ38k63F6pkOUCGCDBITrtsK1rQSnxg= Received: by mail-oi1-f179.google.com with SMTP id v13so2927427oiv.13 for ; Fri, 07 Aug 2020 12:47:22 -0700 (PDT) X-Gm-Message-State: AOAM5326D+Hm7aiRdbcJo5TN5v6ebODX/at8YO+z9pDpTW2UvEBFGDt8 oUVQWr//G/T9lOhNGP2o+uvrQhvD2VNDy6ZGXQ== X-Received: by 2002:aca:bb82:: with SMTP id l124mr12846734oif.106.1596829641729; Fri, 07 Aug 2020 12:47:21 -0700 (PDT) MIME-Version: 1.0 References: <20200611085900.49740-1-tomeu.vizoso@collabora.com> In-Reply-To: <20200611085900.49740-1-tomeu.vizoso@collabora.com> From: Rob Herring Date: Fri, 7 Aug 2020 13:47:10 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] panfrost: Make sure GPU is powered on when reading GPU_LATEST_FLUSH_ID To: Tomeu Vizoso Cc: LKML , Steven Price , Alyssa Rosenzweig , David Airlie , Daniel Vetter , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 11, 2020 at 2:59 AM Tomeu Vizoso wrote: > > Bifrost devices do support the flush reduction feature, so on first job > submit we were trying to read the register while still powered off. > > If the GPU is powered off, the feature doesn't bring any benefit, so > don't try to read. > > Signed-off-by: Tomeu Vizoso > --- > drivers/gpu/drm/panfrost/panfrost_gpu.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) Both patches applied.