Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver
To:     Stephen Boyd <swboyd@chromium.org>, Rob Clark <robdclark@gmail.com>
Cc:     Tanmay Shah <tanmay@codeaurora.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        freedreno <freedreno@lists.freedesktop.org>,
        Sean Paul <seanpaul@chromium.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>, aravindh@codeaurora.org,
        Abhinav Kumar <abhinavk@codeaurora.org>, khsieh@codeaurora.org,
        Chandan Uddaraju <chandanu@codeaurora.org>,
        Vara Reddy <varar@codeaurora.org>
References: <20200807071718.17937-1-tanmay@codeaurora.org>
 <20200807071718.17937-4-tanmay@codeaurora.org>
 <3b0d0e49-5fe8-e217-4ddc-1ff08e65ab48@infradead.org>
 <CAF6AEGv5Yf1x7aCEauP7XtzTjpUCxJt6_GzxFhFXyf_DX_Gi+g@mail.gmail.com>
 <159683184187.1360974.15575847254880429529@swboyd.mtv.corp.google.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <75acac5a-b4a5-9c5a-4404-fb936d738e46@infradead.org>
Date:   Fri, 7 Aug 2020 13:28:38 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <159683184187.1360974.15575847254880429529@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/7/20 1:24 PM, Stephen Boyd wrote:
> Quoting Rob Clark (2020-08-07 08:51:48)
>> On Fri, Aug 7, 2020 at 8:27 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>
>>> On 8/7/20 12:17 AM, Tanmay Shah wrote:
>>>> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
>>>> index ea3c4d094d09..cc1392b29022 100644
>>>> --- a/drivers/gpu/drm/msm/Kconfig
>>>> +++ b/drivers/gpu/drm/msm/Kconfig
>>>> @@ -60,6 +60,7 @@ config DRM_MSM_HDMI_HDCP
>>>>  config DRM_MSM_DP
>>>>       bool "Enable DP support in MSM DRM driver"
>>>>       depends on DRM_MSM
>>>> +     default y
>>>>       help
>>>>         Compile in support for DP driver in msm drm driver. DP external
>>>>         display support is enabled through this config option. It can
>>>
>>> Hi,
>>>
>>> You need a very strong justification to make an optional part of a driver
>>> to be "default y".
>>
>> My opinion is that if the driver is built, everything should be built.
>> This is what makes sense for distro's.  It is only the embedded case
>> where you want to trim down unneeded features where you might want to
>> disable some parts.  So 'default y' makes sense to me.

We don't set defaults for distro convenience.

> 
> Maybe use 'default DRM_MSM' so that it doesn't trigger the 'default y'
> filters people have?

Most people can figure that one out.  ;)
I don't have any automated filters.

-- 
~Randy