Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <159191561875.242598.18326727418245335996@swboyd.mtv.corp.google.com>
References: <1591885683-29514-1-git-send-email-sanm@codeaurora.org> <1591885683-29514-2-git-send-email-sanm@codeaurora.org> <159191561875.242598.18326727418245335996@swboyd.mtv.corp.google.com>
Subject: Re: [PATCH 1/2] clk: qcom: gcc: Add genpd active wakeup flag for sc7180
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Manu Gautam <mgautam@codeaurora.org>,
        linux-clk@vger.kernel.org, Taniya Das <tdas@codeaurora.org>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Doug Anderson <dianders@chromium.org>,
        Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Matthias Kaehlcke <mka@chromium.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Sandeep Maheswaram <sanm@codeaurora.org>
Date:   Fri, 07 Aug 2020 14:44:21 -0700
Message-ID: <159683666176.1360974.5500366475077976771@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Stephen Boyd (2020-06-11 15:46:58)
> Quoting Sandeep Maheswaram (2020-06-11 07:28:02)
> > From: Taniya Das <tdas@codeaurora.org>
> >=20
> > The USB client requires the usb30_prim gdsc to be kept active for
> > certain use cases, thus add the GENPD_FLAG_ACTIVE_WAKEUP flag.
>=20
> Can you please describe more of what this is for? Once sentence doesn't
> tell me much at all. I guess that sometimes we want to wakeup from USB
> and so the usb gdsc should be marked as "maybe keep on for wakeups" with
> the GENPD_FLAG_ACTIVE_WAKEUP flag if the USB controller is wakeup
> enabled?
>=20
> >=20
> > Signed-off-by: Taniya Das <tdas@codeaurora.org>
> > ---
>=20
> Add a Fixes: tag too? And I assume we need to do this for all USB gdscs
> on various SoCs and maybe other GDSCs like PCIe. Any plans to fix those
> GDSCs?
>=20

Any update here?