Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 07 Aug 2020 17:41:04 -0700 (PDT)
Message-Id: <20200807.174104.946455971597492292.davem@davemloft.net>
To:     r.czerwinski@pengutronix.de
Cc:     borisp@mellanox.com, aviadye@mellanox.com,
        john.fastabend@gmail.com, daniel@iogearbox.net, kuba@kernel.org,
        kernel@pengutronix.de, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200806064906.14421-1-r.czerwinski@pengutronix.de>
References: <20200806064906.14421-1-r.czerwinski@pengutronix.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Date: Thu,  6 Aug 2020 08:49:06 +0200

> Trying to use ktls on a system with 32-bit userspace and 64-bit kernel
> results in a EOPNOTSUPP message during sendmsg:
> 
>   setsockopt(3, SOL_TLS, TLS_TX, …, 40) = 0
>   sendmsg(3, …, msg_flags=0}, 0) = -1 EOPNOTSUPP (Operation not supported)
> 
> The tls_sw implementation does strict flag checking and does not allow
> the MSG_CMSG_COMPAT flag, which is set if the message comes in through
> the compat syscall.
> 
> This patch adds MSG_CMSG_COMPAT to the flag check to allow the usage of
> the TLS SW implementation on systems using the compat syscall path.
> 
> Note that the same check is present in the sendmsg path for the TLS
> device implementation, however the flag hasn't been added there for lack
> of testing hardware.
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>

I'll apply this, thank you.