Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp2766298pxa; Fri, 7 Aug 2020 22:07:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwv0nWZEj4QHA/kVcNpm4POnkhC7tsamJqk60YqCcqK3nQIWl0sKw3XsxAD7h0m7zwG8LXH X-Received: by 2002:a17:906:46cc:: with SMTP id k12mr12544997ejs.366.1596863243984; Fri, 07 Aug 2020 22:07:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596863243; cv=none; d=google.com; s=arc-20160816; b=rWtnof3mhZGe5I1YsjLKAJle4lXgw7bBB2m7twHZw8AYYuS07V266IqAGAoxAGZZfM nWLpBAB0jVCPuZ7x+I3YTZJz/jlYZkXo1JziAg1Y4MqFeJx2o6eLWEC0NiLBBKG/qjpe Y0W6sFW9Sfj4vJDqJoo38QfdQQMCBF0GxOy6sym7IIZ9eYXTJDfnsbwOxnF8vGsEUz75 G8yJJAVvW661X6dgp9c1Rmva6lXhQceGr7ZX0dwFMGxiGna8SzEwvlLuXbf/liKDdEys hTJJj7MKDIHiUrIyGmJ14xv6MFTO+YjlSnBkuBdvnPt6USbs2Ro/WFpjiHry+ahpjwfv C6yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=1hjnIkzUTTRYAlAWSGp9lrfHotgmdROoTM927eyuK2w=; b=Fy2KiDhLUVOVTXvplbuOHWPhm78EyiSBW98/6aSJoWYQVBRbbxZ4/3HnsJEdKd3vir Adpe4CgskTKf7ZEMT1yrbHwSp//wS4dh9XE5GWwvuaVw0+nZNybWN5tCE84FRwZW8FoS c1P6mUfV0vIyQ0xryb3LTIIUwG3kqDJ73J01BWz33G5kyQaEWHEX7WjmXKiwkjQdksD0 aG7/OW6FENkLFSU20XCqVVmKQUWJBztqwV28m09XEILpPsfgX5HrIif3uJ685c8rxktD cD7sQuC/EvbX1j4YJijUsnZmNO37dehR26PEtJmKPGnAV2NxSUV7cRkF9J6iP96OcQQ2 kr+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k23si5405668ejg.514.2020.08.07.22.06.58; Fri, 07 Aug 2020 22:07:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726236AbgHHFGY (ORCPT + 99 others); Sat, 8 Aug 2020 01:06:24 -0400 Received: from mga09.intel.com ([134.134.136.24]:1291 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbgHHFGY (ORCPT ); Sat, 8 Aug 2020 01:06:24 -0400 IronPort-SDR: wGKfKHq9ex18F+5zjhqXAAA6zVE6h4EyD0gl6yeMkAGxFgS0YmfRzWjKNX7UieSJRM/lDCMR/V Cxjg/MT/2p3Q== X-IronPort-AV: E=McAfee;i="6000,8403,9706"; a="154400918" X-IronPort-AV: E=Sophos;i="5.75,448,1589266800"; d="scan'208";a="154400918" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2020 22:06:23 -0700 IronPort-SDR: zOIIPvd03rOwBuFsBRe3OPQGX78V6+D/IsczlGRQvTrEDLcXUVo2xor7SfaWtyEIXv+hX84AcL ndDUtMXnQ2Dg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,448,1589266800"; d="scan'208";a="307577088" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.160]) by orsmga002.jf.intel.com with ESMTP; 07 Aug 2020 22:06:23 -0700 Date: Fri, 7 Aug 2020 22:06:23 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Peter Xu , Peter Shier Subject: Re: [PATCH 1/1] kvm: mmu: zap pages when zapping only parent Message-ID: <20200808050623.GA1123@linux.intel.com> References: <20200727203324.2614917-1-bgardon@google.com> <20200804211444.GA31916@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 05, 2020 at 08:48:03PM +0200, Paolo Bonzini wrote: > On 05/08/20 19:10, Ben Gardon wrote: > >> > >> Alternatively, what about moving this logic into mmu_page_zap_pte()? That > >> can be done with a little massaging of FNAME(invlpg) and would avoid what is > >> effectively redundant checks on is_shadow_present_pte() and is_last_spte(). > >> Patches attached and somewhat tested. > > That seems like a good change to me and the patches you attached look > > good to me. I'm happy to review them more if you want to send them to > > the mailing list as their own series. Thanks for putting them > > together. > > > > Thanks, I'll wait for that. Sorry for the delay, been buried with internal stuff. I'll get the series posted on Monday.