Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3200896pxa; Sat, 8 Aug 2020 13:10:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWUwHMmHvW0IyYJyCCkI1qTR2ojFsZo+oYLIaPrKBO7BhwR4UEnGUGlbFZZ0zbMog+OOxF X-Received: by 2002:a50:8f44:: with SMTP id 62mr13594614edy.351.1596917412165; Sat, 08 Aug 2020 13:10:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596917412; cv=none; d=google.com; s=arc-20160816; b=JftuHNvdG8rmQL7asnN7QPYGKG6/8fZR8ql45ZKdura5cPQi9YPWMwVnr7XHMIx36T 2LvR+aVjlO8x4WrKp0v4MWO69yRPQFHiOHc/jf1eegFs6RMyp6O/AtBQDp9HIXkvvDIn FVHU/qF9riSGC0bNEfVL9QI9+LiUjmWMkg9WaHLnbAhmtmXPjyKEH6FJhX1s6skQ+E19 3VO9Hu6ioeCvinpk+dnUurixaYeO8sCLo60C/t3fvzvIa/oyTHw+hTx0HASF/E3tQEum UvHm6wxLys3uuF8dCoM8XSFHKRu1Ne9iE7bIY0P4yCgksUy6/mlTCUyQVxFDo91ScCDL XuwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=SiCenb5vX6dJuKnVeIHYtfpTZiB8QcQyZGTetv9DPOc=; b=GhWTYcxBBBQMKG4Ujk86ofNdR1nwgSWmfIsAfioaGhuCfPwurUh3V7LHhQrpykfmlT 1W5zXW+tHvFcanUMDx+5WMuWfLob5MTED55YzgffgwGVUbJD+Q96o9w+j1E+gQghi5V+ DzPV8RBi/pS4n4TijJpcK9yLRcsAw5ceLw9pGclqIg7j32yvycNyM17aFyyY6BOSaMMM idVX4q4Q/baea0BxbzhAZt5d3kPvez4yhnuU8rn50noyyjg45BMO8DQBpaf6UJ0+pxf0 RO9wUvFoTLz7EaQU7Bq7XBTLgrzxYxIrCLUJriSgjL+p+5vZQZL1A27nug1fYYKf9MNv v+qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lFVDLSY7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k23si6606133ejg.514.2020.08.08.13.09.48; Sat, 08 Aug 2020 13:10:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=lFVDLSY7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726307AbgHHUHM (ORCPT + 99 others); Sat, 8 Aug 2020 16:07:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbgHHUHL (ORCPT ); Sat, 8 Aug 2020 16:07:11 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33A98C061756; Sat, 8 Aug 2020 13:07:11 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id f10so2785340plj.8; Sat, 08 Aug 2020 13:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SiCenb5vX6dJuKnVeIHYtfpTZiB8QcQyZGTetv9DPOc=; b=lFVDLSY7VsBKcLcjFlyRYW5BGeOL+Sx4ZFqlgN3tH75pBxcn+6zjnmCxNhGfVYhYuE Sr1pnCzIyrdU24BuU6L+Vdd0mCqiHjsWx+wEADZL5IkjwUVUnfMIcyrGs+XNAsx63Nn/ kJZBiuZn7mBL28Sn3Hq06N4T59tBRosqBV+e06ndqfCJUY+wpsQvrOcRUALYbXkVTRPt i7pUntfcoD2C8s1STFqKDr937fzT/T1GWAwFyrIX5pLoRjqwMsjxIPbAUGZRx04vWOtZ e2WuRXOr81EgWc7Y2Dm8FiIlI5Kq2stZ79hmF3bDEQZC6Dzf/2s7MvwxgWFwXo3uCMvD h3bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SiCenb5vX6dJuKnVeIHYtfpTZiB8QcQyZGTetv9DPOc=; b=jKH2l7EDmNsvfWCDpVwO/qO9bR2eiOxBTPou0mRSuFgaASYZTllI+3731XThv/Fhz8 e0RgVOEQA1Deti/FE1fJ6cP4oGGDRSZ/xj2YfbGtcdqXes02FgeIT+AZVZUyP+YpVuPS 3qnJnvUotKNzB6VndiqpUT30hrckjY0a4ScvmQwxul2O08kcsQm/4byqudicaYP4GJa3 WLxi+OMi+EoWSB/S0VMAyfD3Eqq7TN1UOyjV+U+Jdg3/8tYWMPHqCECkVfHCxSgT9Tgl 8pL2/S6tOCmTLvLYVs8Jyh+kinghIyjTcwxI7n+vsVXrbA0cLzPloEYlksbZBl5ZINk6 AhpQ== X-Gm-Message-State: AOAM533jo6FGJEQ2Y7B4JlCHNH0FzORj3GfjCe8vIVoXEGCrjz5kreG6 RR1AgswVcMiCIlcklwfri4vPWgJ3BWYul9py88g= X-Received: by 2002:a17:902:4b:: with SMTP id 69mr18475941pla.18.1596917229824; Sat, 08 Aug 2020 13:07:09 -0700 (PDT) MIME-Version: 1.0 References: <20200808121026.1300375-1-cmo@melexis.com> In-Reply-To: <20200808121026.1300375-1-cmo@melexis.com> From: Andy Shevchenko Date: Sat, 8 Aug 2020 23:06:53 +0300 Message-ID: Subject: Re: [PATCH v4 0/4] iio: temperature: mlx90632: Add extended calibration calculations To: Crt Mori Cc: Jonathan Cameron , linux-iio , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 8, 2020 at 3:10 PM Crt Mori wrote: > > Since the second patch is dependent on the first and was still not > merged, I have decided to send them together. First patch just makes > second one more readable as it splits out the repeated calculation and > that enables the second patch to tweak the variable to the new > condition. So, we are closer, but here is one remark, it's not good to send a new version if you are not going to address _all_ comments (it's fine to do, but you need to answer first why you are not going to satisfy them). For example, explicit castings here and there, voodoo arithmetics is left uncommented. -- With Best Regards, Andy Shevchenko