Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3268034pxa; Sat, 8 Aug 2020 16:02:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz387+9mnxoZsBoDNVr9MqRxPEYpKknmsgo2cfuCnmYem1nAyrerBGcSqpBZGak6pLS9BYk X-Received: by 2002:a17:906:b213:: with SMTP id p19mr957477ejz.39.1596927746412; Sat, 08 Aug 2020 16:02:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596927746; cv=none; d=google.com; s=arc-20160816; b=lCnL8fFmffXlKQ9sYafjxRDELNM4U1z9zPEkQggZxaKkm1c00nHdd9YMtPkfiq6ie8 8yE9ZwoXPeF+WJzYvX6id4JhcUcu2RyBXYUsuf1YN2bbNMD2E6dkJUdMkPeC2e84vFY/ jmBehTFEUpk/7PM39qAzkdfL1ZFYDYUYI7crkDyGD2AjstMyVMKKSxThuIj63lqtWlos CWR+1y2QNSOah/fZ188duHKlcJa++mDjWi2Rc2J5PGooWne8hvvjprMGIL1lkbjmuuIt CD/Gzc/0blje4/vzdhw2KaSff4SLjqr60/6EBA+Tkm+jjMSZauJo8Iw9qAvb9jvHFv7B Xd+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=03s0FrguY+5Vsw5VcUN9hRTd+zm+8TlvlWIEd814HQA=; b=jQOlmmxrkMQD3rgGwGIhPLnaJf3n1EtbadloCzm+SEYcXQ3o0GPAA4hsGrgWK9uSRe 8ZztY2zqIO5N702iSz0vKvPpjxgm+j7RbJmmpsoZw65H0xWEdyLKtWlrsCukYi6yN+Xx QMuZXD5CGwIlIbRcEuN2HvjH3D4xt+909ToLEErxAqatNc+NL3qaW5Qf7MBeyPmeu2NA 9vjyzsPGLjjgmWb51GRpsuFOUEUEF/OR0377HpkXWC1WzuZTJBtcVcQZ4QMn3d+L2efH +tLb/wZjb6H6Ykzg48A60YdLcOP+u4MCiakXC6HbDJFh9TSNLx3NbVwqAO0yglvOGbar 5PpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt16si8026064ejb.353.2020.08.08.16.02.02; Sat, 08 Aug 2020 16:02:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726093AbgHHXAW (ORCPT + 99 others); Sat, 8 Aug 2020 19:00:22 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:35551 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbgHHXAW (ORCPT ); Sat, 8 Aug 2020 19:00:22 -0400 Received: by mail-pj1-f68.google.com with SMTP id t6so2845133pjr.0; Sat, 08 Aug 2020 16:00:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=03s0FrguY+5Vsw5VcUN9hRTd+zm+8TlvlWIEd814HQA=; b=jDuY4fCSEWSXhrCCZsIAceb+ZjKs2VlVYFXjuEGnMIoiAOQIlITfuGeBYCh+fzfmFB Bxq4kVZjzEU9wHWzXyUiUDEeEVLdJQ/fK8f8oxX0pOpdhybjqb9abF720i2XFUsj/GRV t+cPv9xo0F7lvdOlziU+F2HofnbBPRJzMBswFbTtCfPUu0fWUTHU7CniFroeu8sfD8dq PDjnSKlAE6OdnYc6Qt8SDu2tJ9N/NrQLBIldOLQyAfMkfuv5OhKHwc85U3v81SqSTsbO 8oXQHtN2O8Yb+FRXykR9MMwyn7sOL+8QBkJdVXvxvo9LheLK352K0IorHqAC2SFGN6M/ lpWA== X-Gm-Message-State: AOAM531FywZkdPT3C93Vge9YHbBpW0Lc+XL5Kp15UKumIw8hF92bJfDS i4XameItQHQn2tkeYEoyV5k= X-Received: by 2002:a17:90b:a45:: with SMTP id gw5mr19388020pjb.80.1596927621388; Sat, 08 Aug 2020 16:00:21 -0700 (PDT) Received: from [192.168.3.217] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id n18sm15064408pgd.91.2020.08.08.16.00.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Aug 2020 16:00:20 -0700 (PDT) Subject: Re: [PATCH v8 1/4] scsi: ufs: Add UFS feature related parameter To: daejun7.park@samsung.com, "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "asutoshd@codeaurora.org" , "beanhuo@micron.com" , "stanley.chu@mediatek.com" , "cang@codeaurora.org" , "tomas.winkler@intel.com" , ALIM AKHTAR Cc: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sang-yoon Oh , Sung-Jun Park , yongmyung lee , Jinyoung CHOI , Adel Choi , BoRam Shin References: <231786897.01596704281715.JavaMail.epsvc@epcpadp2> <231786897.01596705001840.JavaMail.epsvc@epcpadp1> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: Date: Sat, 8 Aug 2020 16:00:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <231786897.01596705001840.JavaMail.epsvc@epcpadp1> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-08-06 02:02, Daejun Park wrote: > @@ -537,6 +548,7 @@ struct ufs_dev_info { > u8 *model; > u16 wspecversion; > u32 clk_gating_wait_us; > + u8 b_ufs_feature_sup; > u32 d_ext_ufs_feature_sup; > u8 b_wb_buffer_type; > u32 d_wb_alloc_units; > Hmm ... shouldn't this variable be introduced in the patch that introduces the code that sets and uses this variable? How about making it clear in the patch subject that this patch adds protocol constants related to HPB? Otherwise this patch looks good to me. Bart.