Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3307850pxa; Sat, 8 Aug 2020 17:38:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznZb1V7h892DC4AHztWXObg2rSrwPsWLqjwRtTA4MooEcDntpb+Nf3zj9MGzTmBe1XxVJp X-Received: by 2002:a05:6402:a5b:: with SMTP id bt27mr15476877edb.120.1596933523133; Sat, 08 Aug 2020 17:38:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596933523; cv=none; d=google.com; s=arc-20160816; b=QpeEOdFfUDSVVnjMmdKpgwYKZ2sPhW8JeAb7VNZ9Qshw/iBfm/YriyM/C2/lx6DbIH 6cmDsorbgQzVo6whn2P7ULMm57pSnWlDY7uv5Jz2S1vKHqMXKzHwUGGBJuVR5V7SPycl mnVgoi0vsEu4LGyn1CVbPHMp8tC0MZmC1awDY0vOEneavOjgMtH2XIy/WKprUGjBW/aN +AYk9Ebdko3ykoGS3sLXeXHYiWzxDhbJu+iTsBOqLM2cpgAzII2UDk7+Ui/fXOduRx93 ejkvgjy5YANgHmfvY9N6hvPD/1iV0fJeNAgdorpvDeaWAQ9sUlTJAaGxY4jVYyPtNC4J kAPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=kBxJUmD5kEHUyP5ytyB2VOYY3FKgBfnpco1mvoA2Uu4=; b=KtwWs71FlkhzLtZfi/Mpn2OqD4yNGxqVBjMX2xPRNFIGTkR2N/13Qb1gYDBTeGuFRj 9t0w7WRW8MofsUgq91VZLGp67haSXooogRwx27qhsALf+8/w/lRagedrVKKNks9IyzSU mjqbhXJO7Ooatd4l39ohYr+f2qttOQtPvfrRgwSNG6YhyTDlfibYHG+8PpTGpkMnoUBc nJQRjnCERz+5BaP/TmJffGT6tLdjj8h7/tsnQLxTLdlgT3c353RQ6ojQykWevqmPNDmB r85bcqF1s5jhhs+/wRci/cM8s3ra5dg7Cunhif04mlcFp0a9YwCANt73TAYizETqp9oA QWWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ch2si7721358edb.244.2020.08.08.17.38.20; Sat, 08 Aug 2020 17:38:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbgHIAfy (ORCPT + 99 others); Sat, 8 Aug 2020 20:35:54 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:42317 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725950AbgHIAfx (ORCPT ); Sat, 8 Aug 2020 20:35:53 -0400 Received: by mail-pf1-f194.google.com with SMTP id 17so3176252pfw.9; Sat, 08 Aug 2020 17:35:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=kBxJUmD5kEHUyP5ytyB2VOYY3FKgBfnpco1mvoA2Uu4=; b=Ic2VdOtYsRE9FDpt3mfP2JAPpqmBpM0Yhr4DZFcOIG2ZqOCHlote7fo4etz5iTqzDN si7fMgYopTP7PAs1nTjsdyQuajQnQtJY7ehYitVbqHEB61o4jiYZsK9uqBsB7CaKb5pM fAF2kLgG0da72h2l3CJq4Lm2+A+WSjGvvPVro5DL4EYnDk9rxwXHMUWzPqrZ8zgusUqv 8086DE0TNYXLJWUdv6p67THjbgpb+i9HWEdD5bhMJk35Ke+h7AnoTgnyvg5Q07Bn4/hF 5WqO8bwJcl0cJ8RZOx2QImj6a59odagElPW1uLXRIf/82IqNN79KDh2urJvf0vVHFnBl CYuQ== X-Gm-Message-State: AOAM5335xiEUvjMRk/jaC22xJnU/ryVp/uqEsTcEOe5iJtBeHY3DC2rn HVFRI6NEx4Dyeht1YoT0eFk= X-Received: by 2002:a63:4f1b:: with SMTP id d27mr16295607pgb.389.1596933352535; Sat, 08 Aug 2020 17:35:52 -0700 (PDT) Received: from [192.168.3.217] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id x9sm15145194pjt.9.2020.08.08.17.35.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Aug 2020 17:35:51 -0700 (PDT) Subject: Re: [PATCH v8 4/4] scsi: ufs: Prepare HPB read for cached sub-region To: daejun7.park@samsung.com, "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "asutoshd@codeaurora.org" , "beanhuo@micron.com" , "stanley.chu@mediatek.com" , "cang@codeaurora.org" , "tomas.winkler@intel.com" , ALIM AKHTAR Cc: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sang-yoon Oh , Sung-Jun Park , yongmyung lee , Jinyoung CHOI , Adel Choi , BoRam Shin References: <336371513.41596705485601.JavaMail.epsvc@epcpadp2> <231786897.01596705302142.JavaMail.epsvc@epcpadp1> <231786897.01596705001840.JavaMail.epsvc@epcpadp1> <231786897.01596704281715.JavaMail.epsvc@epcpadp2> <231786897.01596705781817.JavaMail.epsvc@epcpadp2> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <89f7bd4e-b328-7916-b099-2882d5182236@acm.org> Date: Sat, 8 Aug 2020 17:35:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <231786897.01596705781817.JavaMail.epsvc@epcpadp2> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-08-06 02:18, Daejun Park wrote: > +static inline u32 ufshpb_get_lpn(struct scsi_cmnd *cmnd) > +{ > + return blk_rq_pos(cmnd->request) >> > + (ilog2(cmnd->device->sector_size) - 9); > +} Please use sectors_to_logical() from drivers/scsi/sd.h instead of open-coding that function. > +static inline unsigned int ufshpb_get_len(struct scsi_cmnd *cmnd) > +{ > + return blk_rq_sectors(cmnd->request) >> > + (ilog2(cmnd->device->sector_size) - 9); > +} Same comment here. > +/* routine : READ10 -> HPB_READ */ Please expand this comment. Thanks, Bart.