Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751774AbWEPK4A (ORCPT ); Tue, 16 May 2006 06:56:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751776AbWEPK4A (ORCPT ); Tue, 16 May 2006 06:56:00 -0400 Received: from mail14.syd.optusnet.com.au ([211.29.132.195]:14803 "EHLO mail14.syd.optusnet.com.au") by vger.kernel.org with ESMTP id S1751774AbWEPKz7 convert rfc822-to-8bit (ORCPT ); Tue, 16 May 2006 06:55:59 -0400 From: Con Kolivas To: Christoph Lameter Subject: Re: [PATCH] mm: cleanup swap unused warning Date: Tue, 16 May 2006 20:55:36 +1000 User-Agent: KMail/1.9.1 Cc: linux list , linux-mm@kvack.org, Andrew Morton References: <200605102132.41217.kernel@kolivas.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200605162055.36957.kernel@kolivas.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 24 On Thursday 11 May 2006 09:04, Christoph Lameter wrote: > On Wed, 10 May 2006, Con Kolivas wrote: > > Are there any users of swp_entry_t when CONFIG_SWAP is not defined? > > Yes, a migration entry is a form of swap entry. mm/vmscan.c: In function ‘remove_mapping’: mm/vmscan.c:387: warning: unused variable ‘swap’ Ok so if we fix it by making swp_entry_t __attribute__((__unused__) we break swap migration code? If we make swap_free() an empty static inline function then gcc compiles in the variable needlessly and we won't know it. For the moment let's continue putting up with the warning. -- -ck - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/