Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 9 Aug 2020 08:50:32 +0300
From:   Eli Cohen <eli@mellanox.com>
To:     Alex Dewar <alex.dewar@gmx.co.uk>
Cc:     "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Parav Pandit <parav@mellanox.com>,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: Fix uninitialised variable in core/mr.c
Message-ID: <20200809055032.GA48080@mtl-vdi-166.wap.labs.mlnx>
References: <20200806185625.67344-1-alex.dewar@gmx.co.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200806185625.67344-1-alex.dewar@gmx.co.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mtl-vdi-166.wap.labs.mlnx (94.188.199.18) by AM0PR10CA0037.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:150::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.15 via Frontend Transport; Sun, 9 Aug 2020 05:50:35 +0000
X-Originating-IP: [94.188.199.18]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 2f94133a-db39-4825-4a81-08d83c282305
X-MS-TrafficTypeDiagnostic: AM4PR0501MB2692:
X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM4PR0501MB26920CE608076BAE94CF1680C5470@AM4PR0501MB2692.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 46LfO37tNNKV4jlgYJJVOv91tfQsLGYQnpviHdkU7Ut5hNT/md639Lb1mgRpRyXKYyWepC/H4HiskgERyE9u6QnEEqlfvQZzOwa5M4P8N8HKA4ZKjUVV1LfSVZMaeGKLJ5clzAuE9pORp2O86CS6EuFq2rtG7pzqCW6MDXdLW8QwSLpEUV5bRu0gm+28ipmOK+Jn20BDEEFFFjszfkrsX0qOxN7gLO95w9hIX8JWXsP+gUX78aTZ+ScZQUPeGEHvcLU5ss9ZunF0uhqiTs1+dyZ0/tKRS0+ylwxw7jYawCh8ek38DdaNP409eUCLP0IsI9ZmLSTz90/lb1AI0ZSGPQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR05MB4786.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(346002)(366004)(376002)(136003)(396003)(2906002)(956004)(83380400001)(66476007)(66556008)(6506007)(316002)(26005)(4326008)(16526019)(186003)(6666004)(66946007)(7696005)(52116002)(33656002)(1076003)(54906003)(9686003)(6916009)(8676002)(508600001)(55016002)(86362001)(5660300002)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: jsS4HsC5EOkLHK5PvlSj+NDeWOErdDdboLM12nonA4mHcmzVfPLuEfOePfc3dF/YkG44CLoAX4bGiDRYqFr0uRYL/HqR9Tf9YUmH3t5Tl12lpyT2c/AwNJwPEEKjkV9DzhaaYHnFOiEA9YeB3W9xHmEqQV8ao2/gDmaBCQtebESXkkEfsGBckL26oAqOTR7HsxiXcbcpYZ6++a23JWVHgAfmb+SF9d906zu8rqYY/mXsIGUZ8+FM0QBcWHfqBDpItZ71AbXOOTVEO6fyjby5GB7Nlh0o8JvQMG0DDXL5wu2mB1oohYHo/JxO9mkAcBJCm54agqtepcpvCiD1L7HAZFzbyXvNa2LHIRm9MA6GdU+jdoYWX674JM2sV/5AwG/Kyfb2rUtOEwvpgdzC2ajvnjvOCzFbgav07JgdPp11VsLeIHSvfDkCR8sXA7pxvTK8O8hkaGfTeNkvJ28iY3Z82YQq67n3jjo7U0fHLC9Aeu1glipcUC04owxquF7uGgGK8UErl/Vs7XIcIK3insJYe+spugbazO3YgaEavXMkQR8OvLHLPKl3qW9mivgToa4t512IeMzY7/1BazpzDx97GI1s1rfqqJNtgmgXRGro2+xemaML/95siCRx0Z8UM8nOCRIjJ3J7bWlPWEbHGk/Eyg==
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f94133a-db39-4825-4a81-08d83c282305
X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4786.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2020 05:50:35.9051
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wZq4MLlqbksZlyfJNI0SeOTJtYHJMZmT7tNqa0kJ+AVaT4YxMyhd85GqzVJk9/2lkbydYksoEnUhdWB1/+/70w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2692
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 06, 2020 at 07:56:15PM +0100, Alex Dewar wrote:

Acked-by: Eli Cohen <eli@mellanox.com>
> If the kernel is unable to allocate memory for the variable dmr then
> err will be returned without being set. Set err to -ENOMEM in this
> case.
> 
> Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code")
> Addresses-Coverity: ("Uninitialized variables")
> Signed-off-by: Alex Dewar <alex.dewar@gmx.co.uk>
> ---
>  drivers/vdpa/mlx5/core/mr.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/vdpa/mlx5/core/mr.c b/drivers/vdpa/mlx5/core/mr.c
> index f5dec0274133..ef1c550f8266 100644
> --- a/drivers/vdpa/mlx5/core/mr.c
> +++ b/drivers/vdpa/mlx5/core/mr.c
> @@ -319,8 +319,10 @@ static int add_direct_chain(struct mlx5_vdpa_dev *mvdev, u64 start, u64 size, u8
>  	while (size) {
>  		sz = (u32)min_t(u64, MAX_KLM_SIZE, size);
>  		dmr = kzalloc(sizeof(*dmr), GFP_KERNEL);
> -		if (!dmr)
> +		if (!dmr) {
> +			err = -ENOMEM;
>  			goto err_alloc;
> +		}
> 
>  		dmr->start = st;
>  		dmr->end = st + sz;
> --
> 2.28.0
>