Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 9 Aug 2020 08:52:37 +0300
From:   Eli Cohen <eli@mellanox.com>
To:     Alex Dewar <alex.dewar90@gmail.com>
Cc:     "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Parav Pandit <parav@mellanox.com>,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks
Message-ID: <20200809055237.GB48080@mtl-vdi-166.wap.labs.mlnx>
References: <20200806191849.82189-1-alex.dewar90@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200806191849.82189-1-alex.dewar90@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mtl-vdi-166.wap.labs.mlnx (94.188.199.18) by AM3PR07CA0103.eurprd07.prod.outlook.com (2603:10a6:207:7::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.6 via Frontend Transport; Sun, 9 Aug 2020 05:52:39 +0000
X-Originating-IP: [94.188.199.18]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 38084790-9fd2-47e8-f9de-08d83c286d53
X-MS-TrafficTypeDiagnostic: AM4PR0501MB2692:
X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr,ExtFwd
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM4PR0501MB26923663F15A248C3576565DC5470@AM4PR0501MB2692.eurprd05.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: it2hzExECSkfSFkEt+nPqH7QXqK6O4f5xTzbDVCi+njXHw90FCHJ8iuNmB0y3l+I/H4LI4QmWIHbfTOT/J5JumK3WD/1e0EwngZFcvxBGKfudPZxdLytikI7EZn/ipYDHQ8NjsowiRRjZvnItZgKVvG+PffyHiWqpKDcj984FwPjtsErLHnQfPtsV8qwAxYj+y/R8M1GsGTZIO+q3PbxkkrUyorajbbXA5YUrrku3y+8PMRcoM7M1WSUrVzqVMJCGUQ7QCdAf+mkVCXggTJ3KmwE5azogehggWdAefQZiwg1pU1rPexpP440dI2UCSrMfzaMvpPx2DIJXxXIvczjmg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR05MB4786.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(346002)(366004)(376002)(136003)(396003)(2906002)(956004)(83380400001)(66476007)(66556008)(6506007)(316002)(26005)(4326008)(16526019)(186003)(66946007)(7696005)(52116002)(33656002)(1076003)(54906003)(9686003)(6916009)(8676002)(508600001)(55016002)(86362001)(5660300002)(8936002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: I/QPxRpY4i5zU506Z6k7fzjKhQQpWz/9DUITuFl2XU4TwGCxxOwzuds8AK2yEZ/EEqtrdcL4lliey02NmU/gZjWcHDuFqXTQzwOs/r1+1+Av9nKDelN8LOh7PY0NsxNYRavqkFfiE2w9kkNE84gxsGdrdc8fkMVtUvAKxP3nnMY2GyTWM9bJJgHRIwIq5Qur5B+YsL6giBx46pKxCn3OguVFIsdIzQju7wFCuSy8ftItsCMgsllGB2CKcAr/LKmeKvWuSmRsW0odqmTiM6tmKFEpKTQHEFbthrPfBzJSMaX4LjjMcN2QQoE82KYvK8WmAsbhzucZOaErgkZhM1J5h4kDDZsqMhSOxq7SEjgCGJzsrSWoHnikFj/WJIr87JjFa3LI8sQ0ZwzUDIXf5af7eRe2Js9xKSHhvoMThkuZrCDVmEcYjL89TcoPgtDkq+rJ75YWjkDTXIdhHF+dOfOIXotNUP6zHuxEgBFawrlw4AG59ifrOkCQi2bRcEqILTV+vTepsQpYDuSJqy6lQ60m3zPeZh+/VkM0gJ79vBneoq/fT4cDIVjzgbX4pxIougLcEzISq3i8K01o6svAkCgm17GpTAA0Lbc6ShYggEaWg+H2dI+hHDTB/WorQjJA0nM3aBkaTKlIYrsPRzNSK/sOdQ==
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38084790-9fd2-47e8-f9de-08d83c286d53
X-MS-Exchange-CrossTenant-AuthSource: AM0PR05MB4786.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2020 05:52:40.4842
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aKKCvPCRNJbUPpA6bRRpSAokJZPi4DpRkLCIJOOmvRb7dxbMhR/FgG/s9y3oJJs7OfHHHqzLjNhYcaON5BV1fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2692
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Acked-by: Eli Cohen <eli@mellanox.com>
On Thu, Aug 06, 2020 at 08:18:39PM +0100, Alex Dewar wrote:
> In alloc_inout() in net/mlx5_vnet.c, there are a few places where memory
> is allocated to *in and *out, but only the values of in and out are
> null-checked (i.e. there is a missing dereference). Fix this.
> 
> Addresses-Coverity: ("CID 1496603: (REVERSE_INULL)")
> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
>  drivers/vdpa/mlx5/net/mlx5_vnet.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index 3ec44a4f0e45..bcb6600c2839 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -867,7 +867,7 @@ static void alloc_inout(struct mlx5_vdpa_net *ndev, int cmd, void **in, int *inl
>  		*outlen = MLX5_ST_SZ_BYTES(qp_2rst_out);
>  		*in = kzalloc(*inlen, GFP_KERNEL);
>  		*out = kzalloc(*outlen, GFP_KERNEL);
> -		if (!in || !out)
> +		if (!*in || !*out)
>  			goto outerr;
>  
>  		MLX5_SET(qp_2rst_in, *in, opcode, cmd);
> @@ -879,7 +879,7 @@ static void alloc_inout(struct mlx5_vdpa_net *ndev, int cmd, void **in, int *inl
>  		*outlen = MLX5_ST_SZ_BYTES(rst2init_qp_out);
>  		*in = kzalloc(*inlen, GFP_KERNEL);
>  		*out = kzalloc(MLX5_ST_SZ_BYTES(rst2init_qp_out), GFP_KERNEL);
> -		if (!in || !out)
> +		if (!*in || !*out)
>  			goto outerr;
>  
>  		MLX5_SET(rst2init_qp_in, *in, opcode, cmd);
> @@ -896,7 +896,7 @@ static void alloc_inout(struct mlx5_vdpa_net *ndev, int cmd, void **in, int *inl
>  		*outlen = MLX5_ST_SZ_BYTES(init2rtr_qp_out);
>  		*in = kzalloc(*inlen, GFP_KERNEL);
>  		*out = kzalloc(MLX5_ST_SZ_BYTES(init2rtr_qp_out), GFP_KERNEL);
> -		if (!in || !out)
> +		if (!*in || !*out)
>  			goto outerr;
>  
>  		MLX5_SET(init2rtr_qp_in, *in, opcode, cmd);
> @@ -914,7 +914,7 @@ static void alloc_inout(struct mlx5_vdpa_net *ndev, int cmd, void **in, int *inl
>  		*outlen = MLX5_ST_SZ_BYTES(rtr2rts_qp_out);
>  		*in = kzalloc(*inlen, GFP_KERNEL);
>  		*out = kzalloc(MLX5_ST_SZ_BYTES(rtr2rts_qp_out), GFP_KERNEL);
> -		if (!in || !out)
> +		if (!*in || !*out)
>  			goto outerr;
>  
>  		MLX5_SET(rtr2rts_qp_in, *in, opcode, cmd);
> -- 
> 2.28.0
>