Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Eli Cohen <eli@mellanox.com>
To:     Eli Cohen <eli@mellanox.com>, Alex Dewar <alex.dewar90@gmail.com>
CC:     "Michael S. Tsirkin" <mst@redhat.com>,
        Jason Wang <jasowang@redhat.com>,
        Parav Pandit <parav@mellanox.com>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks
Thread-Topic: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks
Thread-Index: AQHWbCZ0hQUIiLoUFE+0EJhFFNPaH6kvSkSAgAACPhA=
Date:   Sun, 9 Aug 2020 06:03:00 +0000
Message-ID: <AM0PR05MB4786937640988E59BBB453CBC5470@AM0PR05MB4786.eurprd05.prod.outlook.com>
References: <20200806191849.82189-1-alex.dewar90@gmail.com>
 <20200809055237.GB48080@mtl-vdi-166.wap.labs.mlnx>
In-Reply-To: <20200809055237.GB48080@mtl-vdi-166.wap.labs.mlnx>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4253c2f7-6427-4999-7e9e-08d83c29debf
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2020 06:03:00.0563
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lu1Y9neWK4RC7c/1ONhiE0duFzI8dDDGORIirRRbl1KA+zF5Yj89dBJhRlioyd7NpBZ/zhZ319muj4GnaHNPSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB6626
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

After all this patch is not fixing it all. If we get to default of the swit=
ch statement we will free invalid pointer so removing ack-ed by me.

The previous patch by Colin King fixes it.


-----Original Message-----
From: Eli Cohen <eli@mellanox.com>=20
Sent: Sunday, August 9, 2020 8:53 AM
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: Michael S. Tsirkin <mst@redhat.com>; Jason Wang <jasowang@redhat.com>; =
Parav Pandit <parav@mellanox.com>; virtualization@lists.linux-foundation.or=
g; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks

Acked-by: Eli Cohen <eli@mellanox.com>
On Thu, Aug 06, 2020 at 08:18:39PM +0100, Alex Dewar wrote:
> In alloc_inout() in net/mlx5_vnet.c, there are a few places where=20
> memory is allocated to *in and *out, but only the values of in and out=20
> are null-checked (i.e. there is a missing dereference). Fix this.
>=20
> Addresses-Coverity: ("CID 1496603: (REVERSE_INULL)")
> Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5=20
> devices")
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
>  drivers/vdpa/mlx5/net/mlx5_vnet.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c=20
> b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index 3ec44a4f0e45..bcb6600c2839 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -867,7 +867,7 @@ static void alloc_inout(struct mlx5_vdpa_net *ndev, i=
nt cmd, void **in, int *inl
>  		*outlen =3D MLX5_ST_SZ_BYTES(qp_2rst_out);
>  		*in =3D kzalloc(*inlen, GFP_KERNEL);
>  		*out =3D kzalloc(*outlen, GFP_KERNEL);
> -		if (!in || !out)
> +		if (!*in || !*out)
>  			goto outerr;
> =20
>  		MLX5_SET(qp_2rst_in, *in, opcode, cmd); @@ -879,7 +879,7 @@ static=20
> void alloc_inout(struct mlx5_vdpa_net *ndev, int cmd, void **in, int *inl
>  		*outlen =3D MLX5_ST_SZ_BYTES(rst2init_qp_out);
>  		*in =3D kzalloc(*inlen, GFP_KERNEL);
>  		*out =3D kzalloc(MLX5_ST_SZ_BYTES(rst2init_qp_out), GFP_KERNEL);
> -		if (!in || !out)
> +		if (!*in || !*out)
>  			goto outerr;
> =20
>  		MLX5_SET(rst2init_qp_in, *in, opcode, cmd); @@ -896,7 +896,7 @@=20
> static void alloc_inout(struct mlx5_vdpa_net *ndev, int cmd, void **in, i=
nt *inl
>  		*outlen =3D MLX5_ST_SZ_BYTES(init2rtr_qp_out);
>  		*in =3D kzalloc(*inlen, GFP_KERNEL);
>  		*out =3D kzalloc(MLX5_ST_SZ_BYTES(init2rtr_qp_out), GFP_KERNEL);
> -		if (!in || !out)
> +		if (!*in || !*out)
>  			goto outerr;
> =20
>  		MLX5_SET(init2rtr_qp_in, *in, opcode, cmd); @@ -914,7 +914,7 @@=20
> static void alloc_inout(struct mlx5_vdpa_net *ndev, int cmd, void **in, i=
nt *inl
>  		*outlen =3D MLX5_ST_SZ_BYTES(rtr2rts_qp_out);
>  		*in =3D kzalloc(*inlen, GFP_KERNEL);
>  		*out =3D kzalloc(MLX5_ST_SZ_BYTES(rtr2rts_qp_out), GFP_KERNEL);
> -		if (!in || !out)
> +		if (!*in || !*out)
>  			goto outerr;
> =20
>  		MLX5_SET(rtr2rts_qp_in, *in, opcode, cmd);
> --
> 2.28.0
>=20