Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3574743pxa; Sun, 9 Aug 2020 04:49:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzL/I1vQeQ1K8tfXWgmSy3Tnc42rTRBDS4FdhVy4IFziZJ+LShy+Bh75Azrk4BhXwqZdy3 X-Received: by 2002:a17:906:25d0:: with SMTP id n16mr16775206ejb.306.1596973769543; Sun, 09 Aug 2020 04:49:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1596973769; cv=none; d=google.com; s=arc-20160816; b=cwcu2CGrS6JpSaPJ9AllLbrjPIV+jzkfZE9vu4r0XTAw2STjAKps16EQCqSlvN+qYg c+CCjdYqE1JVk8T4+fdSaWFwBx64fi2lrA2F+IKqE28PoYa37fxIf7SCsCQ/YWHXQNBS 8MeGBHYCdYaEcvH31G64MUGOOe3zBsdZLXiGmvBbPqTCtGolHTglZ+dFXYmYKnTVdm/Z xgoZ8xw7GzSJnVGSTJK3kPydVaUBitG90S4qR2P6csME+BTC/5NrYA2PPX2VfwO3Qp8l W1bB7m7cdyUhw6kz8CrDL57Jnu4A1T/ykcSMHLe6znAzA+9DuCo/kw+BcvgEhTyzb28V XRJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=jBq/MPPV3fxt+MVmQUVvAmj7lsePVFh9Dh8sg/hPZ6c=; b=S647iy1lz4wfWpjxFQKxylX3vKeboGaAe5E2MeekExS4EFMd+mV5jv43+OegxeGWGV kLE1V7LgFGkWdv+oaixVrC9WrLevvz3qR+GNz2VF+Pmpy7NSuXgr943vXw0aWOYVLNrE X0LzuZluRf66U0rfuRr4jeovoPdy/08vTk4oonxq6uq90w9/qSA7hfSPaOCXnS6H9Q/H bo94HSVBLinJ3yTzel46t8TWOVmnyVmioh1s04H/aqPHsDq3SOv1/fi1wNqfqp+4Lts2 AQ36AiUAXgwDMoFZIxAMOwYiGHGr46ygQCgNpJ5+7wIJte6Xq4jn0HZdJ+xWbtIJiP5T H6mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2lLYQ+rA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g16si9257287ejf.103.2020.08.09.04.48.52; Sun, 09 Aug 2020 04:49:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2lLYQ+rA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726322AbgHILnn (ORCPT + 99 others); Sun, 9 Aug 2020 07:43:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:33882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726009AbgHILnd (ORCPT ); Sun, 9 Aug 2020 07:43:33 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 951A1206B5; Sun, 9 Aug 2020 11:43:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596973413; bh=dnio2izJ1JeZiTWgd2dGmyXEXTWvquXUnsADWvbcpxM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2lLYQ+rAL0YUCkSEbnhjrH8doIo6J1tkvxKGKJOGsvE1+4z/XUrXcYfKyg/i/Tbff ppnXYsxiOA6dsquFGBhTl32RYD+FUYNnJKLKDJVJeFssM69Yyw6H+cZSfGjgBRKvBv iMPfD3W8tmYWH5DSrobFZIWGLSmgzFfM+3jaRVGU= Date: Sun, 9 Aug 2020 12:43:29 +0100 From: Jonathan Cameron To: Crt Mori Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio:temperature:mlx90632: Some stylefixing leftovers Message-ID: <20200809124329.5ed66c0b@archlinux> In-Reply-To: <20200806212139.923270-1-cmo@melexis.com> References: <20200806212139.923270-1-cmo@melexis.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Aug 2020 23:21:39 +0200 Crt Mori wrote: > There is some inconsistency and whitespace cleanup performed in this > patch. It was done on top of my other patches, but I can rebase to head > of the togreg branch if it would go in sooner. > > Signed-off-by: Crt Mori If not already done so, probably just add this to the other series. If you prefer to keep it separate then remind me if I seem to have lost this one after those patches are in place. Thanks, Jonathan > --- > drivers/iio/temperature/mlx90632.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c > index bb35a65bb9f0..d966e5387c48 100644 > --- a/drivers/iio/temperature/mlx90632.c > +++ b/drivers/iio/temperature/mlx90632.c > @@ -100,10 +100,10 @@ > #define MLX90632_DSP_VERSION 5 /* DSP version */ > #define MLX90632_DSP_MASK GENMASK(7, 0) /* DSP version in EE_VERSION */ > #define MLX90632_RESET_CMD 0x0006 /* Reset sensor (address or global) */ > -#define MLX90632_REF_12 12LL /**< ResCtrlRef value of Ch 1 or Ch 2 */ > -#define MLX90632_REF_3 12LL /**< ResCtrlRef value of Channel 3 */ > -#define MLX90632_MAX_MEAS_NUM 31 /**< Maximum measurements in list */ > -#define MLX90632_SLEEP_DELAY_MS 3000 /**< Autosleep delay */ > +#define MLX90632_REF_12 12LL /* ResCtrlRef value of Ch 1 or Ch 2 */ > +#define MLX90632_REF_3 12LL /* ResCtrlRef value of Channel 3 */ > +#define MLX90632_MAX_MEAS_NUM 31 /* Maximum measurements in list */ > +#define MLX90632_SLEEP_DELAY_MS 3000 /* Autosleep delay */ > #define MLX90632_EXTENDED_LIMIT 27000 /* Extended mode raw value limit */ > > struct mlx90632_data { > @@ -884,7 +884,7 @@ static int mlx90632_probe(struct i2c_client *client, > mlx90632->mtyp = MLX90632_MTYP_EXTENDED; > } else if ((read & MLX90632_DSP_MASK) == MLX90632_DSP_VERSION) { > dev_dbg(&client->dev, > - "Detected Unknown EEPROM calibration %x\n", read); > + "Detected Unknown EEPROM calibration %x\n", read); > } else { > dev_err(&client->dev, > "Wrong DSP version %x (expected %x)\n",