Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200807200957.1269454-1-jim.cromie@gmail.com>
 <20200807200957.1269454-4-jim.cromie@gmail.com> <7e5c90bf-eb04-4b63-2990-7be18e22664f@infradead.org>
In-Reply-To: <7e5c90bf-eb04-4b63-2990-7be18e22664f@infradead.org>
From:   jim.cromie@gmail.com
Date:   Sun, 9 Aug 2020 09:09:46 -0600
Message-ID: <CAJfuBxzafMKtD88TmwYqQ-UuvS1Wvtn1ehz-7gtF8KtiRojFaw@mail.gmail.com>
Subject: Re: [PATCH 3/7] dyndbg: select ZPOOL in Kconfig.debug
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Jason Baron <jbaron@akamai.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Changbin Du <changbin.du@intel.com>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        Krzysztof Kozlowski <krzk@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Aug 8, 2020 at 11:06 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 8/7/20 1:09 PM, Jim Cromie wrote:
> > dyndbg will next need zs_malloc and friends, so add config reqs now,
> > to avoid touching make-deps late in a patch-set.
> >
> > I used select in order not to hide dyndbg inadvertently.
> > I want to say recommends, since it could be an optional feature.
> > Whats the best way ?
>
> Hi Jim,
> Can you elaborate on what/why/when it could be an optional feature?
>

hi Randy,

I dont think making it optional adds any real value.
if ZPOOL/ZRAM/ZSWAP is not included, we dont get any of
that sweet sweet compression. or the off-lining of >1/2 the memory.
I've got 46 callsites enabled atm, which is more than average, ~3100
callsites offlined.
This is the payoff for the added complexity and memory (the site pointer)

fwiw, Im not entirely clear on which of ZPOOL/ZRAM/ZSWAP
is the correct dependency/ies.   ZSWAP feels like the best destination
for the data,
especially if the data can be pushed aggressively into it.