Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp3959485pxa; Sun, 9 Aug 2020 18:19:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1LNwJNbnJ8pQU3ank4YaN1iYZvufWToBLD+qnH7I+xcOaBLqMxBo67XcrvD0FMfxYuqa0 X-Received: by 2002:a05:6402:cb:: with SMTP id i11mr18559500edu.372.1597022392335; Sun, 09 Aug 2020 18:19:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597022392; cv=none; d=google.com; s=arc-20160816; b=pYG4cpfa2ETYnHxZttpTPR3TykgpaWgl2Kq7ExjnQUNUKtFZlz8453cCPaGNfXaONb VCEsaDt4jJQE9Ql95DcKaG4aV2ont3h8ZT8Zfw7ARNJCgX+s4is0LGTin2xLydSmZZIP yO5o30/NQJh2JqfjHDU+77IjqOblZzpI7Ciu2x+Lsn3Whx3kzJTDwitL3G+kEIb2Z5Lm OE+59BOXwl0f1pkTG1anXZ7N37UIO0UD/JkR5AdFSepXLtWlapIp7Es/f8jCe5RXx4kR cUacuQxwyh4/KkCa8NcShHtHvsqPY5iMrDagfQU/IWUYhnfw81Zufhmd4xoE8MStthWB WxqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Nyfj1FeIEmGa4FX3ZpwKHhWFRPMiW2KxfE8B7FuuiRo=; b=nrm+3PXD9rG4/FTYfKORIfgoXVVtWpA2+eHNfz1G3Ss47gg3tNWOLTt99RoEnd3NEw HJhKJ2pZc9dR8Gm7XYBgvdlT8rZbYGMDP6BSQoJ3RtxGsee4DgbPTEN74Css+mvQe3C6 EVryH8BN2YAQ61Y4Fk/SSjHGrJGtPMEBDjxA9tUYyXxxNTRe8Zl2dy1yZFDlDVDiBwty fah64ZUb6vCgjVtHWimXCDpB0UQyj5oxC475S9kP0/J4B1oOGxtITEj9OpsRHia+l2Lo QypuIlJhuSSB5ji9Tq4baS4P2ir+GBShZOr3uGO7nE8yo+FixzKgEVzoRs8FtAxdzhtH 7rmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@flygoat.com header.s=vultr header.b=EEsH19KD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=flygoat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lc6si3935099ejb.23.2020.08.09.18.19.26; Sun, 09 Aug 2020 18:19:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@flygoat.com header.s=vultr header.b=EEsH19KD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=flygoat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726415AbgHJBSH (ORCPT + 99 others); Sun, 9 Aug 2020 21:18:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726398AbgHJBSG (ORCPT ); Sun, 9 Aug 2020 21:18:06 -0400 Received: from vultr.net.flygoat.com (vultr.net.flygoat.com [IPv6:2001:19f0:6001:3633:5400:2ff:fe8c:553]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 954DAC061756; Sun, 9 Aug 2020 18:18:06 -0700 (PDT) Received: from localhost.localdomain (unknown [IPv6:2001:da8:20f:4430:250:56ff:fe9a:7470]) by vultr.net.flygoat.com (Postfix) with ESMTPSA id 424221FEB9; Mon, 10 Aug 2020 01:18:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=flygoat.com; s=vultr; t=1597022285; bh=8jQ64yO0EFa1VJiLGME1MgLg11GF98tS7gIUdOBhOiQ=; h=From:To:Cc:Subject:Date:From; b=EEsH19KDnT1uEf4a0B9NIhWOOU6stKWgPIlQlNyf1tFohCU6+sDlevBNZYeoIXnKu jBb12KbUfFWx0XytP/6KnJaSstuzquOS8M1HxxCsFvQM+tBJPoKsuyaHTxd/nKLMzE Qlsj8iOkPey4IxTTBE+05/3pg3Yab/5j4pH1J6PkM6l/U+hkMn/lLxaEs+Er24Qhtv XvGkfcteTSjL1KvWZyakXbSsdbpgzczz8JbhvbYeE5G2ktAbl+/XDxEs3DdBhHO5P2 dboxNGj0cLxEOjieFR/q6Fv8Zjez89fVeKns9Thb97wfvOoKTSW0BVzp4Le7/Ln44Y VkbbCAyyckmRQ== From: Jiaxun Yang To: kvm@vger.kernel.org Cc: pbonzini@redhat.com, Jiaxun Yang , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND for-5.9] MIPS: KVM: Convert a fallthrough comment to fallthrough Date: Mon, 10 Aug 2020 09:17:49 +0800 Message-Id: <20200810011749.3211128-1-jiaxun.yang@flygoat.com> X-Mailer: git-send-email 2.28.0.rc1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a fallthrough comment being forgotten, GCC complains about it: arch/mips/kvm/emulate.c: In function kvm_mips_emulate_load: arch/mips/kvm/emulate.c:1936:21: error: this statement may fall through 1936 | vcpu->mmio_needed = 1; /* unsigned */ | ~~~~~~~~~~~~~~~~~~^~~ arch/mips/kvm/emulate.c:1939:2: note: here 1939 | case lw_op: Just fix it. Signed-off-by: Jiaxun Yang Reviewed-by: Huacai Chen --- This is blocking KVM MIPS from build, so it needs to get into 5.9. --- arch/mips/kvm/emulate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c index 703782355318..d70c4f8e14e2 100644 --- a/arch/mips/kvm/emulate.c +++ b/arch/mips/kvm/emulate.c @@ -1935,7 +1935,7 @@ enum emulation_result kvm_mips_emulate_load(union mips_instruction inst, case lwu_op: vcpu->mmio_needed = 1; /* unsigned */ - /* fall through */ + fallthrough; #endif case lw_op: run->mmio.len = 4; -- 2.28.0.rc1