Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ionic_lif: Use devm_kcalloc() in ionic_qcq_alloc()
To:     Joe Perches <joe@perches.com>, Xu Wang <vulab@iscas.ac.cn>,
        drivers@pensando.io, davem@davemloft.net, kuba@kernel.org,
        netdev@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <20200810023807.9260-1-vulab@iscas.ac.cn>
 <4265227298e8d0a943ca4468a4f32222317df197.camel@perches.com>
From:   Shannon Nelson <snelson@pensando.io>
Message-ID: <2623670b-09f0-2ab4-d618-e478d98c186a@pensando.io>
Date:   Sun, 9 Aug 2020 20:50:01 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <4265227298e8d0a943ca4468a4f32222317df197.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/9/20 8:20 PM, Joe Perches wrote:
> On Mon, 2020-08-10 at 02:38 +0000, Xu Wang wrote:
>> A multiplication for the size determination of a memory allocation
>> indicated that an array data structure should be processed.
>> Thus use the corresponding function "devm_kcalloc".
> []
>> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> []
>> @@ -412,7 +412,7 @@ static int ionic_qcq_alloc(struct ionic_lif *lif, unsigned int type,
>>   
>>   	new->flags = flags;
>>   
>> -	new->q.info = devm_kzalloc(dev, sizeof(*new->q.info) * num_descs,
>> +	new->q.info = devm_kcalloc(dev, num_descs, sizeof(*new->q.info),
>>   				   GFP_KERNEL);
>>   	if (!new->q.info) {
>>   		netdev_err(lif->netdev, "Cannot allocate queue info\n");
> You could also remove these unnecessary allocation error messages.
> There is an existing dump_stack() on allocation failure.
>
Yes, the dump_stack() tells you which function had the allocation 
failure, but since there are multiple allocation operations in this same 
function, I find these helpful in knowing quickly which one of the 
allocations failed, without having to track down the symbols and source 
for whatever distro's kernel this might have happened in.

sln