Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp4026564pxa; Sun, 9 Aug 2020 21:07:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyE6LFPDqqXgCxgibWHUwyuqaWloURt0wpb+rh6Gco0FJnvyxwIo9KXRYnPgrzOE9uBcSlI X-Received: by 2002:a17:907:7204:: with SMTP id dr4mr19287344ejc.258.1597032435333; Sun, 09 Aug 2020 21:07:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597032435; cv=none; d=google.com; s=arc-20160816; b=zLM1rvGZQ0L4TzSeC25tcWQPYHm57OcLbbR22l7m4r+YP4QLCSmWrJmrgssjD/bito NUsnCo5hlO3oRvisSQQWsUU8DInS21uQWxlwwJf4tU8rhVoE8euQ53BzRhKeQjdhjUV1 4YpoO8EMb+brt+nYJvNMUiBIveHtxJfw8b2LwH1EgIIX6fCwmMxRbWiYupQjvyi3Xcvx mIwK5Iq60uCp7TcoT8EJBG1ueF0AadCUdMg1Vr0C7o8KTkBGFil+9R/2xfQLl76cDdKx 6Cr6kOS3hlZ5Qbv2Z4/fVxNDbnQRU3gl5m18yoMj4B1vo6N0/F/lBF58slutS5krf0r7 4e/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=9UmCJ3Gzc2kzx0laWLHz4isPjpIvJjC8b4LmNiodLdI=; b=djwgy/Sn7mbgsx7tpClNirRlZPMp9ok8tWWu5uhQzmj+VEgFBIWrMM8zqCWJ9xnGrS YdxfS1XhaGIhDGh68zeMz0eljnCe0jd4n+MKW+n4IcFIptxgZ3ma923ITCxBfcyUcWzH 6SN9QDQfDydXCc/Z8liKpQpwhhHpmIk4FwBG/GR47NfzOBTLa0RykOTXNXToxUUpwlMy +cVxM6Oo/V7gD9JGxut+oARysu4R3kUGz96dbzyDoNTJvRQs/kQYRSjAdV1vk181M+IA tc5+Yi4D0XyRD6KVqsEGtShzARcxJjmaooztg/rvTHCmQYQ9JS1oeHzAG+20cElRLSpF 5aXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a42si3181842edf.570.2020.08.09.21.06.52; Sun, 09 Aug 2020 21:07:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725849AbgHJEGT (ORCPT + 99 others); Mon, 10 Aug 2020 00:06:19 -0400 Received: from mail.loongson.cn ([114.242.206.163]:41100 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725536AbgHJEGT (ORCPT ); Mon, 10 Aug 2020 00:06:19 -0400 Received: from bogon.localdomain (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dx2MW2xzBfIqoGAA--.995S2; Mon, 10 Aug 2020 12:06:14 +0800 (CST) From: Youling Tang To: Josh Poimboeuf , Peter Zijlstra Cc: linux-kernel@vger.kernel.org Subject: [PATCH] tools/objtool: Fix unnecessary jumps Date: Mon, 10 Aug 2020 12:06:14 +0800 Message-Id: <1597032374-7936-1-git-send-email-tangyouling@loongson.cn> X-Mailer: git-send-email 2.1.0 X-CM-TRANSID: AQAAf9Dx2MW2xzBfIqoGAA--.995S2 X-Coremail-Antispam: 1UD129KBjvJXoW7AFW7XrWfCr18AFyfCF4xtFb_yoW8Gw18pF sak34UGryFgFWrGa4xtanxGF9FkrZ7WrW7Wry7C3W7Zr4Yvws8tw1ayF1ayF4fG3yfGa1U XF43WFZrCF12kaDanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUk2b7Iv0xC_Zr1lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwV C2z280aVCY1x0267AKxVWxJr0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xv F2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r4j6F 4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCY02Avz4vE14v_Gryl42xK 82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGw C20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1Y6r17MIIYrxkI7VAKI48J MIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMI IF0xvE42xK8VAvwI8IcIk0rVW3JVWrJr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2 z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUs1xRDUUUU X-CM-SenderInfo: 5wdqw5prxox03j6o00pqjv00gofq/ Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no need to jump to the "out" tag when "ret < 0", just return directly to "ret". Signed-off-by: Youling Tang --- tools/objtool/check.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index e034a8f..94b166d 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -2799,7 +2799,7 @@ int check(const char *_objname, bool orc) ret = decode_sections(&file); if (ret < 0) - goto out; + return ret; warnings += ret; if (list_empty(&file.insn_list)) @@ -2808,7 +2808,7 @@ int check(const char *_objname, bool orc) if (vmlinux && !validate_dup) { ret = validate_vmlinux_functions(&file); if (ret < 0) - goto out; + return ret; warnings += ret; goto out; @@ -2823,35 +2823,35 @@ int check(const char *_objname, bool orc) ret = validate_functions(&file); if (ret < 0) - goto out; + return ret; warnings += ret; ret = validate_unwind_hints(&file, NULL); if (ret < 0) - goto out; + return ret; warnings += ret; if (!warnings) { ret = validate_reachable_instructions(&file); if (ret < 0) - goto out; + return ret; warnings += ret; } if (orc) { ret = create_orc(&file); if (ret < 0) - goto out; + return ret; ret = create_orc_sections(&file); if (ret < 0) - goto out; + return ret; } if (file.elf->changed) { ret = elf_write(file.elf); if (ret < 0) - goto out; + return ret; } out: -- 2.1.0