Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp4104979pxa; Mon, 10 Aug 2020 00:16:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8ozzQ1kbV4B4EgAfde/MMKGZGqnLrumsUYBP04dngOtEoFtyhKVZcFrj/y76QUcUNQyAp X-Received: by 2002:a17:906:c1d7:: with SMTP id bw23mr10509403ejb.315.1597043783524; Mon, 10 Aug 2020 00:16:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597043783; cv=none; d=google.com; s=arc-20160816; b=A0WubbIRWEe5MQqjJqUiXWQbXoT04k+hO/UEiaUixTWcJ69XMWrGwG+pAarAigPHfu LkuvB9bNDvDNhXAznOPcUEzvTcCVKmCVzask0CpGBUAnPPPaqzVRMtn9KPKKroXoJKMF mQjVOjCXI85qFZDEnp+k8uj+NZNwu4f7/hdry8RSpKnXt6kNBQhylCkBeZ/TvOxd656t nd+zAX9TpV9UaC8x+sr4pNCFC/rTfrGfgOrbTlj0K9QZTVPIkAo77nQ5E0Mvyylbk70/ b9wlqk2eQY4PJoyw0uQGgLBBPPbSxsAXhA3jp7Vnu5VfNfZ6YKzOq1e8R1hbVKo6BjRM WO4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=OzGXro9iLMCh57TZ72fiBMjYtaaITfNfK4CpTLhCHL8=; b=TSZu31bMTtNm33JxtGy+vmOK7NOHDPC0FABjJ/zboYTJKzc57xzHP9YMOf9F19U2PZ xqASjjAszhRmd4gEnwDyHZO33mAz3UuqrfAA9MtwLLiAaoHmtxlfomjnE/acctgyde3U Pi1XCLXCm4Mx/k8ScPbD41Jf6a/WnOAWCQilrjU1JbyLEc3QB62tdJSQgGg3vXS1D/iG R/FrweRAUQ/DVkUfW2tjB2JHGAwbb6ySrYHer5Bs+U19PB46qOJ99fi+kh8aR7ef9YCd mZgRyj5+S2Vo8TqYA8y2JseS9CYBWqes9r6oNE4LIFasbpdaSmoioDkyCI+9AleC2wSX vqdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b=GxbelMg7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=st.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d23si9419839edr.58.2020.08.10.00.16.00; Mon, 10 Aug 2020 00:16:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b=GxbelMg7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726448AbgHJHNR (ORCPT + 99 others); Mon, 10 Aug 2020 03:13:17 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:23244 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbgHJHNE (ORCPT ); Mon, 10 Aug 2020 03:13:04 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07A71xAU026940; Mon, 10 Aug 2020 09:12:52 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=STMicroelectronics; bh=OzGXro9iLMCh57TZ72fiBMjYtaaITfNfK4CpTLhCHL8=; b=GxbelMg77eE+iGw57FqJ0I3/VGoj4sif7HFku7TxpIfnfVKfo47AXy6UXMTVQDTduHJv FiFA8PGYelUB3PP+puiYf7TZh1ECpyC+dvt2cWCXK+NiOV0J4FCZU6eODQREfSU2zOvZ oba/aNuY8LfCV4PA618qumws20PcK82+mTlo7Y4AOmY3nrFUAa/G8G90W3ofQNsQ7ZnA 9+bohqOpCstnCv5SoOc48Ue/ajLmMb3o683hJ6wJqkPj9nw7v8gMbnc1Iry+NfumIwua gYGXtv2JlZXBL4eZPnaydaq+vNQCo++LIxnk3h8AonJiFm7AH0r2jyOL9UyzqWhmFFnR FA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 32smf968j4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Aug 2020 09:12:52 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id CC9AB10002A; Mon, 10 Aug 2020 09:12:50 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id BB8872AD9EB; Mon, 10 Aug 2020 09:12:50 +0200 (CEST) Received: from localhost (10.75.127.46) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 10 Aug 2020 09:12:50 +0200 From: Alain Volmat To: , CC: , , , , , , , Subject: [PATCH v2 1/5] spi: stm32h7: fix race condition at end of transfer Date: Mon, 10 Aug 2020 09:12:34 +0200 Message-ID: <1597043558-29668-2-git-send-email-alain.volmat@st.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1597043558-29668-1-git-send-email-alain.volmat@st.com> References: <1597043558-29668-1-git-send-email-alain.volmat@st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-08-10_02:2020-08-06,2020-08-10 signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Antonio Borneo The caller of stm32_spi_transfer_one(), spi_transfer_one_message(), is waiting for us to call spi_finalize_current_transfer() and will eventually schedule a new transfer, if available. We should guarantee that the spi controller is really available before calling spi_finalize_current_transfer(). Move the call to spi_finalize_current_transfer() _after_ the call to stm32_spi_disable(). Signed-off-by: Antonio Borneo Signed-off-by: Alain Volmat --- v2: identical to v1 drivers/spi/spi-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 4a21feae0103..814a3ec3b8ad 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -971,8 +971,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) spin_unlock_irqrestore(&spi->lock, flags); if (end) { - spi_finalize_current_transfer(master); stm32h7_spi_disable(spi); + spi_finalize_current_transfer(master); } return IRQ_HANDLED; -- 2.7.4