Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ccq1VdklxOsyfwLdHtMJy17BZsUAYEBUTDfV2sbPYEigm5B5oW1yQitWfrNqQ2GsUV8Odyhnw7
 C93hlaX9IkWw==
IronPort-SDR: /2Jp4bEPh+V7KeT1K5ze5iC8VDHbLjj1GWEoHp0YU2+2xvgRlxykNgi5D7tUjn5F3/Nr7TaBUf
 /rd3mzFaoPOw==
From:   "Xia, Hui" <hui.xia@intel.com>
To:     Christoph Hellwig <hch@lst.de>, lkp <lkp@intel.com>
CC:     "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>
Subject: RE: [kbuild-all] Re: fs/init.c:72:8: warning: Variable 'error' is
 reassigned a value before the old one has been used.
Thread-Topic: [kbuild-all] Re: fs/init.c:72:8: warning: Variable 'error' is
 reassigned a value before the old one has been used.
Thread-Index: AQHWbUZqh9dN3DXNf0+0JSI5NuZG1akxFqVQ
Date:   Mon, 10 Aug 2020 09:28:27 +0000
Message-ID: <MN2PR11MB40642475AE2B0194F7BEE9C8E5440@MN2PR11MB4064.namprd11.prod.outlook.com>
References: <202008081143.D8Y8xO2X%lkp@intel.com>
 <20200808054006.GA16706@lst.de>
In-Reply-To: <20200808054006.GA16706@lst.de>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 06da4a88-de85-4c6e-80e6-08d83d0fbcea
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2020 09:28:27.5334
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FoLxRgNU/qWVpL+SO9RqvXwgTqDGWYm0PbEvGl2K4i+T0Uo9XDwOuMKFWFt7VqECMjsay++0I1BT0CHjpyQRnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4061
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>-----Original Message-----
>From: Christoph Hellwig <hch@lst.de>
>Sent: 2020=1B$BG/=1B(B8=1B$B7n=1B(B8=1B$BF|=1B(B 13:40
>To: kernel test robot <lkp@intel.com>
>Cc: Christoph Hellwig <hch@lst.de>; kbuild-all@lists.01.org; linux-
>kernel@vger.kernel.org; viro@zeniv.linux.org.uk
>Subject: [kbuild-all] Re: fs/init.c:72:8: warning: Variable 'error' is rea=
ssigned a
>value before the old one has been used.
>
>On Sat, Aug 08, 2020 at 11:35:45AM +0800, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g=
it master
>> head:   30185b69a2d533c4ba6ca926b8390ce7de495e29
>> commit: 4b7ca5014cbef51cdb99fd644eae4f3773747a05 init: add an init_chroo=
t
>helper
>> date:   8 days ago
>> compiler: hppa-linux-gcc (GCC) 9.3.0
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>>
>> cppcheck warnings: (new ones prefixed by >>)
>>
>> >> fs/init.c:72:8: warning: Variable 'error' is reassigned a value
>> >> before the old one has been used. [redundantAssignment]
>>     error =3D security_path_chroot(&path);
>>           ^
>>    fs/init.c:69:8: note: Variable 'error' is reassigned a value before t=
he old one
>has been used.
>>     error =3D -EPERM;
>>           ^
>>    fs/init.c:72:8: note: Variable 'error' is reassigned a value before t=
he old one
>has been used.
>>     error =3D security_path_chroot(&path);
>
>I really don't understand the warning.  We assign a value to error, if the=
re is an
>error we jump the out labe and return it, or else continue.
>
>That is a pretty common pattern in the kernel.  What do I miss?

Please ignore this report. It is false positive.
We will double check this type of warning in future. Sorry for inconvenient=
.

Thanks,
Hui
>
>>
>> vim +/error +72 fs/init.c
>>
>>     57
>>     58	int __init init_chroot(const char *filename)
>>     59	{
>>     60		struct path path;
>>     61		int error;
>>     62
>>     63		error =3D kern_path(filename, LOOKUP_FOLLOW |
>LOOKUP_DIRECTORY, &path);
>>     64		if (error)
>>     65			return error;
>>     66		error =3D inode_permission(path.dentry->d_inode, MAY_EXEC |
>MAY_CHDIR);
>>     67		if (error)
>>     68			goto dput_and_out;
>>     69		error =3D -EPERM;
>>     70		if (!ns_capable(current_user_ns(), CAP_SYS_CHROOT))
>>     71			goto dput_and_out;
>>   > 72		error =3D security_path_chroot(&path);
>>     73		if (error)
>>     74			goto dput_and_out;
>>     75		set_fs_root(current->fs, &path);
>>     76	dput_and_out:
>>     77		path_put(&path);
>>     78		return error;
>>     79	}
>>     80
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>---end quoted text---
>_______________________________________________
>kbuild-all mailing list -- kbuild-all@lists.01.org To unsubscribe send an =
email to
>kbuild-all-leave@lists.01.org