Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp4185503pxa; Mon, 10 Aug 2020 03:06:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyijpIQKkv+hwB2amnC0iMZh6y49Wfa4hgInFq/BX5KbDdTvKq6uzKyNPrbD8FcE0I7KxNh X-Received: by 2002:a05:6402:13d4:: with SMTP id a20mr20794483edx.161.1597053974947; Mon, 10 Aug 2020 03:06:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597053974; cv=none; d=google.com; s=arc-20160816; b=E7kF1J4K9WLojSc7IBPZa9ALCMds0KcwnFdB0zbeJPfAsKB9N0Jwd/DOwcxGN9wC46 WfL0oaRsx57aiPWrriBVK6iAFwx/EG/rAczwKOr2aOnTPSJXVQqGNpmSauKwqfOrrxY1 2nsK25I9NNpFkMhsf5laiBY0Xowh6km7qW9bRQJnbv3T1m6yPsjLSaceEjLK+eGGXgQq 91Cpf9njbguVLXMmUaPhqhUIUZAfX1GIVujFxjeq8QEsOp247pZc7uk20f3CA+IqVgog 7jrp8JIIn/Su2xJa/pg3oGQd9Q3glna+5R1czSRzGeEVttuMjeUIe1xl+rAMWaoc1abS Oi3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=9v5zDAT0O8mvgUwgaFMeBbh4jwHtIc6gCbsE/y7Cl7A=; b=G6FC/O6WDr4WtR4ZZP/nmojxamVeoRTfhp8JL0RwEzKPa2/YqQQ/YiCwRxjW7I/ALA fKCKmx/s1asUtg6rAi3zXJdkndxP3DjQAkSwUUvnYdaIsiBh3iKLyQ60pnoaCCArDIR1 ZeqZtEPsnZzQLrNNYIBMwF3BxziwQTQCHtokDVFduGwUXW5144aO+/TQQi/7jFXLkmxU YbZW9rCjPtOB6vQ1k16cN6aub0XHSAfvdZy8BhGsYucLuczJKpO1lWQoQ4+Ktl5G0HkJ RxEu31sH89oAtqDeRGMIR3Uxgq1cfv11gZ0tWUv2x2V9joXylgADA7DbFMGgW8EfZvCX 0Ang== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hSaka4gx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mb5si1296518ejb.206.2020.08.10.03.05.52; Mon, 10 Aug 2020 03:06:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hSaka4gx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726479AbgHJKEv (ORCPT + 99 others); Mon, 10 Aug 2020 06:04:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:58386 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726173AbgHJKEv (ORCPT ); Mon, 10 Aug 2020 06:04:51 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 987E220709; Mon, 10 Aug 2020 10:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597053891; bh=mvCtbaQWqQwxaFpcHbRDygRoOjwTGaYJbnOoivqrt3A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hSaka4gxJb2Zgqr8ZCaGdaJ/fDgmdCQmQdBD+FpBRnvznQSPc1hvnQAcdG9z8E4sR Z+r+NwV4I6nbaqCmCs94L02L/dyqrEQsgZJBUOoZ9mu9NaGC8uyWceNr0qefGA2QVI j9cAprsqDFUUUY8+a3Jg4P9pPxWaDSJ3O64w2ug4= Date: Mon, 10 Aug 2020 12:05:02 +0200 From: Greg KH To: "Ahmed S. Darwish" Cc: bigeasy@linutronix.de, linux-kernel@vger.kernel.org, linux@roeck-us.net, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org, tglx@linutronix.de, will@kernel.org Subject: Re: [PATCH] Revert "seqlock: lockdep assert non-preemptibility on seqcount_t write" Message-ID: <20200810100502.GA2406768@kroah.com> References: <20200810085954.GA1591892@kroah.com> <20200810095428.2602276-1-a.darwish@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200810095428.2602276-1-a.darwish@linutronix.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 10, 2020 at 11:54:28AM +0200, Ahmed S. Darwish wrote: > This reverts commit 859247d39fb008ea812e8f0c398a58a20c12899e. > > Current implementation of lockdep_assert_preemption_disabled() uses > per-CPU variables, which was done to untangle the existing > seqlock.h<=>sched.h 'current->' task_struct circular dependency. > > Using per-CPU variables did not fully untangle the dependency for > various non-x86 architectures though, resulting in multiple broken > builds. For the affected architectures, raw_smp_processor_id() led > back to 'current->', thus having the original seqlock.h<=>sched.h > dependency in full-effect. > > For now, revert adding lockdep_assert_preemption_disabled() to > seqlock.h. > > Reported-by: Guenter Roeck > Link: https://lkml.kernel.org/r/20200808232122.GA176509@roeck-us.net > Link: https://lkml.kernel.org/r/20200810085954.GA1591892@kroah.com > References: Commit a21ee6055c30 ("lockdep: Change hardirq{s_enabled,_context} to per-cpu variables") > Signed-off-by: Ahmed S. Darwish Reviewed-by: Greg Kroah-Hartman Even after this, there are still some build errors on arm32, but I don't think they are due to this change: ERROR: modpost: "__aeabi_uldivmod" [drivers/net/ethernet/sfc/sfc.ko] undefined! ERROR: modpost: "__bad_udelay" [drivers/net/ethernet/aquantia/atlantic/atlantic.ko] undefined! thanks, greg k-h