Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200810092208.27320-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20200810092208.27320-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <CAMuHMdUiRHEYnL-7mbYKVDESBcDbEeCzNYGeamEAie+bYh_Fug@mail.gmail.com>
In-Reply-To: <CAMuHMdUiRHEYnL-7mbYKVDESBcDbEeCzNYGeamEAie+bYh_Fug@mail.gmail.com>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Mon, 10 Aug 2020 11:35:09 +0100
Message-ID: <CA+V-a8skEg0VRPJkOQFdcU5wraFp0E5Z55T0QVofuAjLauTerg@mail.gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: renesas: r8a774e1: Add VSP instances
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Magnus Damm <magnus.damm@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Geert,

Thank you for the review.

On Mon, Aug 10, 2020 at 11:29 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Mon, Aug 10, 2020 at 11:22 AM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > From: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> >
> > The RZ/G2H (R8A774E1) has 6 VSP instances.
> >
> > Based on the work done for r8a7795 SoC.
> >
> > Signed-off-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> > @@ -2374,6 +2374,72 @@
> >                         status = "disabled";
> >                 };
> >
> > +               vspbc: vsp@fe920000 {
> > +                       compatible = "renesas,vsp2";
> > +                       reg = <0 0xfe920000 0 0x8000>;
> > +                       interrupts = <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD 624>;
> > +                       power-domains = <&sysc R8A774E1_PD_A3VP>;
> > +                       resets = <&cpg 624>;
> > +
> > +                       renesas,fcp = <&fcpvb1>;
> > +               };
> > +
> > +               vspbd: vsp@fe960000 {
> > +                       compatible = "renesas,vsp2";
> > +                       reg = <0 0xfe960000 0 0x8000>;
> > +                       interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
> > +                       clocks = <&cpg CPG_MOD 626>;
> > +                       power-domains = <&sysc R8A774E1_PD_A3VP>;
> > +                       resets = <&cpg 626>;
> > +
> > +                       renesas,fcp = <&fcpvb1>;
>
> According to "FCPVB0 (for VSPBD): H' FE96_F000", this should be
>
>     renesas,fcp = <&fcpvb0>;
>
> ? If you agree, I can fix that while applying.
>
Agreed should be fcpvb0, thank you for taking care of it.

Cheers,
Prabhakar

> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-devel for v5.10.
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds