Subject: Re: [PATCH] Register sysfs file for hotpluged new node
From: Dave Hansen <haveblue@us.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-mm <linux-mm@kvack.org>,
       Linux Kernel ML <linux-kernel@vger.kernel.org>
In-Reply-To: <20060516210608.A3E5.Y-GOTO@jp.fujitsu.com>
References: <20060516210608.A3E5.Y-GOTO@jp.fujitsu.com>
Content-Type: text/plain
Date: Tue, 16 May 2006 07:51:31 -0700
Message-Id: <1147791091.6623.93.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 794
Lines: 23

On Tue, 2006-05-16 at 21:23 +0900, Yasunori Goto wrote:
> +       /*
> +        * register this node to sysfs.
> +        * this is depends on topology. So each arch has its own.
> +        */
> +       if (new_pgdat){
> +               ret = arch_register_node(nid);
> +               BUG_ON(ret);
> +       } 

Please don't do BUG_ON()s for things like this.  Memory hotplug _should_
handle failures from top to bottom and not screw you over.  It isn't a
crime or a bug to be out of memory.  

Have you run this past the ppc maintainers?

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/