Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp4291909pxa; Mon, 10 Aug 2020 05:58:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw49Qa9i3TgpT+m+ivYK1MiLMynldYxh/BFkXkoBfpcIyilOxPqsHBjVEebwL0sdVFJIbPZ X-Received: by 2002:a17:906:8050:: with SMTP id x16mr20967633ejw.441.1597064294998; Mon, 10 Aug 2020 05:58:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597064294; cv=none; d=google.com; s=arc-20160816; b=kRiSHcyS6R+/Pez8H7MzV1rjtJSCNi/SvMZt3xhgp71vOhmI6ngGa+NkHN9IIvio0K HKNRMQdjRiqkCx2SvI6wvIPZEi/S5Vh0HJFHH1upYXxZv+M8onGpTiL9R86um4VGehE+ UOFjVpjMjtMSsy+DKI1iabCFNjMx/0neXfvQGYbBW+4BICs3jxWfEe+CyLx8Z8gFhOhC WodisftM4zneD8yywNNKC1Nucx4prNiRyg81eRkA2nJFO0oGX87dgthgwKHphBe1mZDB PbqV6Nj53icIeLmF1ztk8MAySRvM3MpUIhxtSlJPZ7nyGMoS+AX+Dq26iheznmzLTrwa YdoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=duzwr1ufoYQYn5lcQxOZuSHpm6qYU/HFjB6C0iOegpY=; b=bbOPpKt/JaY5mgKs4wMOm5ilEP6E0w4YAJmullZQFt/Uu8oTPLF0Jl+8XTGr1Ool7C K4vK8ttJUrqkXFaqA3xAv8FT7enVnncQzPXAQDYiMhyRzqp2Ir9CY2iGNPCeN7PHGwXW ppxJTo1BadozmPw6U9CY7TUrYpQHvqKIwHiYPIYVsnjYjhnDxhoiLrM979BGgFg4e/O7 0TccHqF3yj/TC7/xnHYY3zOGBmB02bs6gUQRz4iBkIO32t8nFpfvw9kvOl40kUr4j9Ec nOZ9rHbH7u4c6Ud4A/quuuXLiBrzLz+67BZ9CJcfV98ymVvyeCBOV3pXZegweHBv/EKv vl1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l7si10283812eja.172.2020.08.10.05.57.52; Mon, 10 Aug 2020 05:58:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726715AbgHJM5Q (ORCPT + 99 others); Mon, 10 Aug 2020 08:57:16 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:33004 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726446AbgHJM5Q (ORCPT ); Mon, 10 Aug 2020 08:57:16 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id CB8E1FF15D6C8BBB2C41; Mon, 10 Aug 2020 20:57:13 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Mon, 10 Aug 2020 20:57:07 +0800 From: Qinglang Miao To: David Airlie , Daniel Vetter , "Greg Kroah-Hartman" CC: , , Subject: [PATCH] drm/vgem: add missing platform_device_unregister() in vgem_init() Date: Mon, 10 Aug 2020 20:59:42 +0800 Message-ID: <20200810125942.186637-1-miaoqinglang@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When vgem_init() get into out_put, the unregister call of vgem_device->platform is missing. So add it before return. Fixes: 363de9e7d4f6 "drm/vgem: Use drmm_add_final_kfree" Signed-off-by: Qinglang Miao --- drivers/gpu/drm/vgem/vgem_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index a775feda1..313339bbf 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -471,8 +471,8 @@ static int __init vgem_init(void) out_put: drm_dev_put(&vgem_device->drm); + platform_device_unregister(vgem_device->platform); return ret; - out_unregister: platform_device_unregister(vgem_device->platform); out_free: -- 2.25.1