Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Subject: Re: [PATCH] tools/objtool: Fix unnecessary jumps
To:     Youling Tang <tangyouling@loongson.cn>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org
References: <1597032374-7936-1-git-send-email-tangyouling@loongson.cn>
Message-ID: <bbe25938-479d-7a84-b1ee-941ad8088a1c@linux.vnet.ibm.com>
Date:   Mon, 10 Aug 2020 18:27:01 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1597032374-7936-1-git-send-email-tangyouling@loongson.cn>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/08/20 9:36 am, Youling Tang wrote:
> There is no need to jump to the "out" tag when "ret < 0", just return
> directly to "ret".
> 
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
> ---
>  tools/objtool/check.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index e034a8f..94b166d 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c

[snip]

> 
>  	if (file.elf->changed) {
>  		ret = elf_write(file.elf);
>  		if (ret < 0)
> -			goto out;
> +			return ret;
>  	}
> 
>  out:

the out label code is no more required with this change, so remove
it and return 0 for warnings for now.  Previously cleanup() function
was called under the out label for both fatal errors (ret < 0) and
warnings.  Now that cleanup() function is removed, the out label is
no longer required.

-- 
Kamalesh