Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 10 Aug 2020 15:13:16 +0200
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Qinglang Miao <miaoqinglang@huawei.com>
Cc:     Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/v3d: convert to use module_platform_driver
Message-ID: <20200810131316.GV2352366@phenom.ffwll.local>
Mail-Followup-To: Qinglang Miao <miaoqinglang@huawei.com>,
        Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20200810125931.186456-1-miaoqinglang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200810125931.186456-1-miaoqinglang@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 10, 2020 at 08:59:31PM +0800, Qinglang Miao wrote:
> Get rid of boilerplate code by using module_platform_driver macro
> for v3d_drm.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>

lgtm, merged to drm-misc-next for 5.10
-Daniel

> ---
>  drivers/gpu/drm/v3d/v3d_drv.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
> index 82a7dfdd1..9f7c26193 100644
> --- a/drivers/gpu/drm/v3d/v3d_drv.c
> +++ b/drivers/gpu/drm/v3d/v3d_drv.c
> @@ -358,18 +358,7 @@ static struct platform_driver v3d_platform_driver = {
>  	},
>  };
>  
> -static int __init v3d_drm_register(void)
> -{
> -	return platform_driver_register(&v3d_platform_driver);
> -}
> -
> -static void __exit v3d_drm_unregister(void)
> -{
> -	platform_driver_unregister(&v3d_platform_driver);
> -}
> -
> -module_init(v3d_drm_register);
> -module_exit(v3d_drm_unregister);
> +module_platform_driver(v3d_platform_driver);
>  
>  MODULE_ALIAS("platform:v3d-drm");
>  MODULE_DESCRIPTION("Broadcom V3D DRM Driver");
> -- 
> 2.25.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch