Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp4338459pxa; Mon, 10 Aug 2020 06:57:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySF+DNGIQ51eYKIh5oHELSsXZn/YTPhmXJaQXVr/ZiGM8Vl9DhVzPxqQV6o9CXNUDgTLRo X-Received: by 2002:a50:d2c7:: with SMTP id q7mr20345417edg.61.1597067840984; Mon, 10 Aug 2020 06:57:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597067840; cv=none; d=google.com; s=arc-20160816; b=t22GhnTVnHgk0moiAWeri2WiGZgDX8nSrHjmtBhRUi4y75i1+XsAjgyLEnyfcYSdPJ xdFn7dzi1bfR0akIU1XxTJvPc672olGvcAtJ+E1O8NJaQGrzKiZeO5kAo4fQAIijT48u ScuMtxfIwOge6ZvpBOTkOEeEUBQz1YcOORkdgxWzKSb7t5ZRHipTQyW55zx4irUQNYoX seYXOJzMk3PyomC8oW04mcQNcGB5xwN0iowA0QoWnoHL0P3qJTmrfkz1WwdhWknu8Y2k 22J/xWrMLeJSRRGXDQ/3wtniYUAUo9FyUAsu9LhgHsrr/or9HWS3uSuyCjh7SJw6/N3u VjLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:message-id:date:subject:cc :to:from:ironport-sdr:ironport-sdr; bh=RM7vVFz9EkN4OSDAgX+6cWS7Qdo6UDEYav7lkpe+uhY=; b=eP5CULSC7l9Up8ziiH8/kDbGpPPrEoNx/YGSMI+0HBnE0b1fgkmiheA3jYoy+Okj2v an32TYeFxVlotQS9JEd+JgHXLFuHlQs4OhRUxz5G4iQdnxc5lKKrym5eNgUa9YMYlC4G 50XfwBkgYUX+tgR2UJ3xpdvhjQAukJtrbNIqwCJqThSb6mNZ3fxTp/EvA3qnVVeitA9o 8lejTBt8zKlndV4P4xMDgmf/h+JINJJY10T3rvUqSBOr5boOWFQr6ozsDpd1DT698ta5 y4SeYZN6NIhHVp9A04C6I2ddrilYo+a19cfZupH4g6M8qXTVZ3dPSVCQESGtUkipEme7 PmYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c15si10817884edv.479.2020.08.10.06.56.57; Mon, 10 Aug 2020 06:57:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726897AbgHJN4S (ORCPT + 99 others); Mon, 10 Aug 2020 09:56:18 -0400 Received: from mga07.intel.com ([134.134.136.100]:57142 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726584AbgHJN4R (ORCPT ); Mon, 10 Aug 2020 09:56:17 -0400 IronPort-SDR: XvilRj2iXmnNwIUST0GTon9Kl1/icsf3a2vLMdwiJY6PqJZpERprDsccyhXiJnfVf2E6jjU1uK CDRDzQ3JMS6Q== X-IronPort-AV: E=McAfee;i="6000,8403,9708"; a="217872756" X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="217872756" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2020 06:56:17 -0700 IronPort-SDR: 1ehKgvCEhhWCVQg3p77Ejt+HJGi+3UlrMZjk/x1oa1PrZDOAiCiSTuW8hU3roy/hanBsgE81UW ZPAVfhzGMVZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,457,1589266800"; d="scan'208";a="469052846" Received: from ahunter-desktop.fi.intel.com ([10.237.72.73]) by orsmga005.jf.intel.com with ESMTP; 10 Aug 2020 06:56:14 -0700 From: Adrian Hunter To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Alim Akhtar , Avri Altman , Venkat Gopalakrishnan , Can Guo Subject: [PATCH 1/2] scsi: ufs: Fix interrupt error message for shared interrupts Date: Mon, 10 Aug 2020 16:55:47 +0300 Message-Id: <20200810135548.28213-1-adrian.hunter@intel.com> X-Mailer: git-send-email 2.17.1 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The interrupt might be shared, in which case it is not an error for the interrupt handler to be called when the interrupt status is zero, so remove the message print and register dump. Signed-off-by: Adrian Hunter Fixes: 9333d77573485 ("scsi: ufs: Fix irq return code") --- drivers/scsi/ufs/ufshcd.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index cdcf56679b41..d7522dba4dcf 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -5994,12 +5994,6 @@ static irqreturn_t ufshcd_intr(int irq, void *__hba) intr_status = ufshcd_readl(hba, REG_INTERRUPT_STATUS); } while (intr_status && --retries); - if (retval == IRQ_NONE) { - dev_err(hba->dev, "%s: Unhandled interrupt 0x%08x\n", - __func__, intr_status); - ufshcd_dump_regs(hba, 0, UFSHCI_REG_SPACE_SIZE, "host_regs: "); - } - spin_unlock(hba->host->host_lock); return retval; } -- 2.17.1