Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp4340825pxa; Mon, 10 Aug 2020 07:00:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz0dV0v7fdYhR2AiujnVeroXoSwvtVByV1tQDKoXKWWgCkH+iblSLbUVxG7BK2M4Tsw+nh7 X-Received: by 2002:a05:6402:17bb:: with SMTP id j27mr20603112edy.291.1597068041187; Mon, 10 Aug 2020 07:00:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597068041; cv=none; d=google.com; s=arc-20160816; b=IrfV+WvuOq+/Rjn0v6SC6/RWcKSwgqHqqsLdK1cXfG1J2y0qJBTEwIwO1/pYM+nkoq tF1GMht5O3N5a7MKfziSRNHgvRp3bWtI67H9lUE/0JXmxjxHrHcEdga6m1uEN9wvyCJz FS1nmixbFEytq9OY65LxzU8YsHDsf/9jRtdWjYA9j/EgH1F/waz4k8xufcnoOycKHVuD 2F+A3VGOu48lxxRWfMbdbNVr3kKp7kQJ9jGylmb0/CFncndLDt34T3taQhnrcGLSV75e D4LR+jd6oTkLysFmKeDp4Hv18yapVabnjxAZv9lcA4z3uUydM8NyEmB0mNpUKKC/m8KV +I3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=4Dxv+S0H3yRud7A0uxMosMb6e1a88KqNNH92czrJNiQ=; b=Pn6AYB/Qwty54f/GieJhDpA+nofxgwl5puKSQbS25cdeYPe45xMZeKsCImvJ1Gzm1W sv6tONj8SzdprohlBCsbEnEymd9mo2WVyGgWGVc3FfsDP0dGC35bAK5uuI7oviNsrB9f zZrs+ohjyko2rF/3FkXTw++hCk4i+np9Nf5ABdiOM07J4vZ5Eucw9ckDf5cYc8859He/ ji2L6NWz7wplg5ZZN6cAmBdc/dFgK2auuFdtHfWjvITU8ZajrBg9KjLWckZP5mGvy63R EVi6VQvNrpq704dQDkpStG5AaOP2GPG4R3fqIzN27pGwujdaoXxUfDX1oDHdL1IORPi2 QMPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rh17si10185316ejb.256.2020.08.10.07.00.18; Mon, 10 Aug 2020 07:00:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbgHJN5M (ORCPT + 99 others); Mon, 10 Aug 2020 09:57:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726584AbgHJN5L (ORCPT ); Mon, 10 Aug 2020 09:57:11 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62322C061756; Mon, 10 Aug 2020 06:57:11 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1k58I5-0002a7-W0; Mon, 10 Aug 2020 15:56:42 +0200 Date: Mon, 10 Aug 2020 15:56:41 +0200 From: Florian Westphal To: Miaohe Lin Cc: davem@davemloft.net, kuba@kernel.org, pshelar@ovn.org, martin.varghese@nokia.com, fw@strlen.de, dcaratti@redhat.com, edumazet@google.com, steffen.klassert@secunet.com, pabeni@redhat.com, shmulik@metanetworks.com, kyk.segfault@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: eliminate meaningless memcpy to data in pskb_carve_inside_nonlinear() Message-ID: <20200810135641.GE19310@breakpoint.cc> References: <20200810122856.5423-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200810122856.5423-1-linmiaohe@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miaohe Lin wrote: > The skb_shared_info part of the data is assigned in the following loop. Where?