Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp4392203pxa; Mon, 10 Aug 2020 08:05:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoaunggOKTOSjZzTq7DlAfoQOOgRI6LDBDhuEfAY18BRcG4TCMnLtlVukvc9GbM8f8GMGs X-Received: by 2002:a50:93c5:: with SMTP id o63mr21161332eda.31.1597071942316; Mon, 10 Aug 2020 08:05:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597071942; cv=none; d=google.com; s=arc-20160816; b=nLIv4ndPxBVysOP/xaUqOgS5kTkhb2mTTaugOMCLvlTJQMPlDyAELdeJYxaeS2LRsC M1Reu0d6mWTGwE332Pz3prIHvA3eQwJvbPu9qenwzcArfvqvR/g4r29qTzpZICYzoIm1 aA0N6qgoVPpc5R2aXoxm1TS42B8Gy5C6/SotXNatAv58rA53ryrsf5IeaOrU1Zd/7SUc xT8nmKtyHHSxOsJJ/PtiQ/SnEME4KsieuUK9VyKK9LaNgviuv0B1/AVkPW90s+d/FF8f qU2Q7Akw1S/HpEcTKX/fH1OsxFhY38B8CcA1ppzMA2+WVbtwPmsxc40eP6VdU/r96kmm T09g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=dXmPHq8wPjYagFFl/MlKXsLVV4NdJMMG+sxOv0/am9c=; b=MLDGpSzNrY45pk0oM7zEhHQc12URI0H07JtLfIiLt2OkYYsNZEu+1Bjp1Lc1f1QORO sL29uTV0JnpHzKz8tMd8gNrMk+fXaUgAFqCXd7EokTkdhqC+Sj1+wrv41QJb9/4N7SD+ Hx+JzksCTfH3xao77N4F5byeDYOQneUXlpwUiqzQFR5PHcCmQrQjeZy53oF4Ju4K0r1x 6jyEex9LBM8EE0NL5ae9PK4L//7ImWc/bqE9l8gu8k1JK+EWmd7YVCo7irCuNoIICdg8 7FYSwMnqdlpOAjxCVCPmHnDYnK/BEFbwde/DiZ1wpO3e2yVbf/GxPR5QRrXV03YEsXuT LHOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b="g/35rZdj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn20si3406135ejc.104.2020.08.10.08.05.17; Mon, 10 Aug 2020 08:05:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b="g/35rZdj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727104AbgHJPEU (ORCPT + 99 others); Mon, 10 Aug 2020 11:04:20 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:60166 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726499AbgHJPET (ORCPT ); Mon, 10 Aug 2020 11:04:19 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07AEuejV030055; Mon, 10 Aug 2020 15:04:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=dXmPHq8wPjYagFFl/MlKXsLVV4NdJMMG+sxOv0/am9c=; b=g/35rZdjC4JdwZkisiUDvBcETWYpQ/n82Hjnsmo9ToIfurBltK8orNluP1srqakEbxH5 jem8HqtTwdBfdUfElwfZR/cDwmd+L9+ibYjLuvRspwIp2WAhMwbHuW3WI1DEDJnFdV4+ XYzAV9i24BuLTSNOaHXHpqzSvXWD/GE7v4diD8F7yzVk4WcIX8hg5jv2ply970BFcl4s z/42cdMZIjHKdLR2Z1EMDFjFvXOufRg2J9F7xxiTitDafgQk5TLThplpRtsj/9XuOtdP /eqQel/gMzjoGhoCuuGpA0slbHBrh10GalbPCqYtzcz7Ro0MiViiLg/M3TFZDK7eSWWr sA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 32sm0mf2ev-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 10 Aug 2020 15:04:08 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07AEwMRl184935; Mon, 10 Aug 2020 15:04:07 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 32t5ywut3g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Aug 2020 15:04:07 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07AF45ot016098; Mon, 10 Aug 2020 15:04:05 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 10 Aug 2020 15:04:04 +0000 Date: Mon, 10 Aug 2020 18:03:56 +0300 From: Dan Carpenter To: Vaibhav Agarwal Cc: Greg Kroah-Hartman , Alex Elder , Johan Hovold , Mark Greer , devel@driverdev.osuosl.org, greybus-dev@lists.linaro.org, Colin Ian King , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] staging: greybus: audio: fix uninitialized value issue Message-ID: <20200810150356.GL1793@kadam> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9709 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008100112 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9709 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 clxscore=1011 suspectscore=0 mlxlogscore=999 priorityscore=1501 adultscore=0 impostorscore=0 spamscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008100112 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 06, 2020 at 09:51:57PM +0530, Vaibhav Agarwal wrote: > diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c > index 2f9fdbdcd547..4b914d0edef2 100644 > --- a/drivers/staging/greybus/audio_topology.c > +++ b/drivers/staging/greybus/audio_topology.c > @@ -456,6 +456,13 @@ static int gbcodec_mixer_dapm_ctl_put(struct snd_kcontrol *kcontrol, > val = ucontrol->value.integer.value[0] & mask; > connect = !!val; > > + ret = gb_pm_runtime_get_sync(bundle); > + if (ret) > + return ret; > + > + ret = gb_audio_gb_get_control(module->mgmt_connection, data->ctl_id, > + GB_AUDIO_INVALID_INDEX, &gbvalue); We need to check "ret" after this. > + > /* update ucontrol */ > if (gbvalue.value.integer_value[0] != val) { > for (wi = 0; wi < wlist->num_widgets; wi++) { > @@ -466,16 +473,10 @@ static int gbcodec_mixer_dapm_ctl_put(struct snd_kcontrol *kcontrol, regards, dan carpenter