Received: by 2002:a05:6a10:a0d1:0:0:0:0 with SMTP id j17csp4455958pxa; Mon, 10 Aug 2020 09:27:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGhBl593auH80bb1laYQcxjqx50kilwV/dQVyWmsitm32YiJd2+Z0ukEZgi0lL5naNal0f X-Received: by 2002:a17:906:2e93:: with SMTP id o19mr23647976eji.167.1597076842271; Mon, 10 Aug 2020 09:27:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597076842; cv=none; d=google.com; s=arc-20160816; b=bkTEpwKSAoSthqxSwnivzeqys7qda6AIYjPtTMZPbBQM3W6+0OfjVFvBrLP3Bd99dx S+8jah49k4cFkTEyox1ofEY4+Up/4x//EjXYnrjbguzMEJN9Xz5THWHhLhZLZuX3xwLf 3D5h+g8Y9UN/c2o8isR2WSGen5pEhZ803FYEo1xOpZ1TzEqTmUavoe1PocGw4bZaN/vX StHSOTQUh3uAncOLVEBZPKLvLydoVvquIE6FQ8BJE7DWkMmT9WA2MJsn76p2/laglfRw ru62U+/I2zCZAuLXBVKjOqwg02sJet4Hy1L2Uo/kqH0G9UKTaHc5Jy/Z78pm+k1NvhqU tlvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=37FWOUijhIdnSXEJOtvy1P/xTgq3uubVSZ2PCc8Tqmw=; b=adw8OU2jALF4/OVf3h3jQjw/0SKBg9OHDNbHfMMm4IxiFsZ9k360xrCvEJOV/GcOFx 7COIDJQrl7Aap+puJ7F2YWwzzhaP+M5+q5gTC4DPFUIzW0Ou/25PXVxBs6/cnNyQH6X7 UOQ2fFyeFIA+ZRA3hYclGJUBy2RT41iUee7opw5NwM2iRtS8b4V/cJHSqRBAUXIHY4Sg 6hKfdbnu7oiHTkiZ3cEfvqpZa6u8AKmjTiPNTcaYLhqOZ2SsWXYpR80CsNsqQ4l2wkFi wj0kJtAfDXqzM2FChCisE6jCK3Kjz/QCwfX/+myBvJazR+nXtZgHLFwau8IKL7Z+vafB ZftQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=hW9j33LE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f17si11314466ejb.624.2020.08.10.09.26.59; Mon, 10 Aug 2020 09:27:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@rere.qmqm.pl header.s=1 header.b=hW9j33LE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727018AbgHJQ0A (ORCPT + 99 others); Mon, 10 Aug 2020 12:26:00 -0400 Received: from rere.qmqm.pl ([91.227.64.183]:41914 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726338AbgHJQZ7 (ORCPT ); Mon, 10 Aug 2020 12:25:59 -0400 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4BQLtZ0yqrz2d; Mon, 10 Aug 2020 18:25:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1597076758; bh=8mCk9Jx3F4pOPDKskEp8Z8k7Z55vu8IimoDHIF4fU60=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hW9j33LEo1/ymEM5pn9EyKLiOD3Kxbh5Qx6CVI/Fy6rzD38uiBkv2CnS3G0LFEaee fSOhrIwzk3f4LmapiD6r3rVum+ds3tnryCgcZMtjRe4hLnG51/K9378u4Z+f6bsIVF IxS3t/MZ+KCubkH5fvgc+QVo5qLbzTUqNBy0cIojd1OnjpvfpH54OlgroameMy40Ey CCKrGwvj/yWPMmaNC7jobVn7Cu16Z2/f3Z7xoK3P2m0eaAqQkcNwkwwe2olSVtBfJf 3jcgZdkbq9Bdg7J83m62WthFR0SjpHEJmObGae9av8JC+J+XQxTvTIC3gTr6l/BxY4 /dZ+6bkZxXWog== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.4 at mail Date: Mon, 10 Aug 2020 18:25:56 +0200 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Mark Brown Cc: Dmitry Osipenko , Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: fix pointer table overallocation Message-ID: <20200810162556.GA3394@qmqm.qmqm.pl> References: <407fbd06a02caf038a9ba3baa51c7d6d47cd6517.1597000795.git.mirq-linux@rere.qmqm.pl> <5ef51b56-c533-46c8-621d-7907129594e9@gmail.com> <20200810123747.GC6438@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200810123747.GC6438@sirena.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 10, 2020 at 01:37:47PM +0100, Mark Brown wrote: > On Sun, Aug 09, 2020 at 10:44:25PM +0300, Dmitry Osipenko wrote: > > 09.08.2020 22:21, Michał Mirosław пишет: > > > The code allocates sizeof(regulator_dev) for a pointer. Make it less > > > generous. Let kcalloc() calculate the size, while at it. > > > > > > Cc: stable@vger.kernel.org > > > Fixes: d8ca7d184b33 ("regulator: core: Introduce API for regulators coupling customization") > > > Hello, Michał! Thank you for the patch! Not sure whether it's worthwhile > > to backport this change since it's an improvement, I'll leave it to Mark > > to decide, otherwise looks good to me. > > Yeah, this is more a performance improvement than a fix. Should I resend without Cc: stable? Best Regards, Michał Mirosław